Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ *: upgrade kube-rbac-proxy to v0.8.0 #1955

Merged
merged 2 commits into from Jan 20, 2021
Merged

✨ *: upgrade kube-rbac-proxy to v0.8.0 #1955

merged 2 commits into from Jan 20, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Jan 16, 2021

This PR upgrades kube-rbac-proxy image version from v0.5.0 to v0.8.0, which has a rootless feature and no breaking changes (afaik).

Closes #1785

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2021
@estroz
Copy link
Contributor Author

estroz commented Jan 19, 2021

/retest

1 similar comment
@estroz
Copy link
Contributor Author

estroz commented Jan 19, 2021

/retest

@estroz
test commit
8d108aa 
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@estroz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-15-3 8d108aa link /test pull-kubebuilder-e2e-k8s-1-15-3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@estroz
Copy link
Contributor Author

estroz commented Jan 20, 2021

Looks like there's some issue with k8s v1.15.3 resulting in kube-rbac-proxy:v0.8.0 [not being pullable](failed to unpack image on snapshotter overlayfs: content digest sha256:5a9f8e2f60fc4d02e364fa0192c01c79e8fac7e0c6a01cbc5b17152d6f21deae: not found). I think I've reproduced this locally; v1.15.13 works fine. Will update the prow config then rerun these tests.

@estroz
Copy link
Contributor Author

estroz commented Jan 20, 2021

Blocked on kubernetes/test-infra#20530

camilamacedo86
camilamacedo86 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terrific 🥇

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3af7d23 into kubernetes-sigs:master Jan 20, 2021
@estroz estroz deleted the deps/krp-v0.8.0 branch January 20, 2021 19:53
@camilamacedo86 camilamacedo86 mentioned this pull request Jan 21, 2021
Merged
2 tasks
@s-urbaniak s-urbaniak mentioned this pull request Jan 29, 2021
Closed
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 7, 2021
Merged
1 task
camilamacedo86 added a commit to operator-framework/operator-sdk that referenced this pull request Feb 10, 2021
@camilamacedo86
Fix kube rbac proxy (#4498)
d1c14c4 
**Description of the change:**

-   For Ansible/Helm based-operators, upgrade the `kube-rbac-proxy` image version from `0.5.0` to `0.8.0` to address security concerns. More info [#kubernetes-sigs/kubebuilder#1955](kubernetes-sigs/kubebuilder#1955).


**Motivation for the change:**

- Closes: #3925
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update kube-rbac-proxy to v0.8.0 release
3 participants
@estroz @k8s-ci-robot @camilamacedo86