Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for go 1.22 #3910

Merged
merged 1 commit into from
May 16, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 16, 2024

✨ Add support for go 1.22

Closes: #3792

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ Add support for go 1.22 WIP: ✨ Add support for go 1.22 May 16, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Add support for go 1.22 ✨ Add support for go 1.22 May 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@camilamacedo86
Copy link
Member Author

/override pull-kubebuilder-e2e-k8s-1-30-0

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-30-0

In response to this:

/override pull-kubebuilder-e2e-k8s-1-30-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit eda2819 into kubernetes-sigs:master May 16, 2024
37 checks passed
@camilamacedo86 camilamacedo86 deleted the upgrade branch May 16, 2024 17:27
@mikeee
Copy link

mikeee commented May 17, 2024

@camilamacedo86 Hi! Sorry I'm not familiar with the kubebuilder release cadence, when would the next release be published that includes this fix?

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 17, 2024

Hi @mikeee

@camilamacedo86 Hi! Sorry I'm not familiar with the kubebuilder release cadence, when would the next release be published that includes this fix?

All that is merged in the master go to the next release.
Include this one :-)

PS.: It is not a fix. We add the support to new go versions when we have those bumped in the other k8s projects used by us too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for go 1.22
3 participants