Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/jobset from 0.3.2 to 0.4.0 #1785

Merged
merged 1 commit into from Mar 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps sigs.k8s.io/jobset from 0.3.2 to 0.4.0.

Release notes

Sourced from sigs.k8s.io/jobset's releases.

v0.4.0

What's Changed

New Contributors

Full Changelog: kubernetes-sigs/jobset@v0.4.0-devel...v0.4.0

Commits
  • 9f2cb14 Merge pull request #432 from danielvegamyhre/title
  • 55a38c0 update title and subtitle
  • f70676c Merge pull request #431 from kubernetes-sigs/dependabot/go_modules/kubernetes...
  • cb29842 Bump the kubernetes group with 5 updates
  • 68e9aaa Merge pull request #426 from googs1025/main
  • 70e6f9b typo: Fix some comments
  • d0d32af Merge pull request #424 from danielvegamyhre/docs-0.3.2
  • b3c8776 update installation docs for v0.3.2
  • 5f2220c Merge pull request #421 from danielvegamyhre/val-err-msg
  • 15c24a3 add leader pot not scheduled info log
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1b465d5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65ef46e52ff81200082e03ce
😎 Deploy Preview https://deploy-preview-1785--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@kannon92
Copy link
Contributor

kannon92 commented Mar 4, 2024

/hold

test failure look legit.

mind if I look into it? I’d like to get more familiar with Jobset integration.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

/hold

test failure look legit.

mind if I look into it? I’d like to get more familiar with Jobset integration.

Thank you for your help.

@alculquicondor
Copy link
Contributor

/approve cancel

@trasc
Copy link
Contributor

trasc commented Mar 4, 2024

/hold

test failure look legit.

mind if I look into it? I’d like to get more familiar with Jobset integration.

I think something changed in the fake client

-	sigs.k8s.io/controller-runtime v0.17.0
+	sigs.k8s.io/controller-runtime v0.17.2

The Jobset integration might not have anything to do with it.

@alculquicondor
Copy link
Contributor

If that's the case, could you try upgrading controller-runtime in a separate PR and fixing the tests that need fixing?

@alculquicondor
Copy link
Contributor

Or report a bug in controller-runtime, if the change in the fake client is not acceptable.

@kannon92
Copy link
Contributor

kannon92 commented Mar 4, 2024

I tried to update jobset without controller-runtime but it seems to want to update.

I tried just bumping the go.sum for jobset and running go mod tidy but it updates controller-runtime.

@alculquicondor
Copy link
Contributor

we'll have to update controller-runtime at some point regardless, so try that separately first

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

I tried to update jobset without controller-runtime but it seems to want to update.

I tried just bumping the go.sum for jobset and running go mod tidy but it updates controller-runtime.

Please check this PR: kubernetes-sigs/controller-runtime#2681

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

/approve cancel
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.3.2 to 0.4.0.
- [Release notes](https://github.com/kubernetes-sigs/jobset/releases)
- [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/jobset@v0.3.2...v0.4.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/jobset
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/jobset-0.4.0 branch from 4b20e7f to 1b465d5 Compare March 11, 2024 18:01
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2024
@kannon92
Copy link
Contributor

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a834354cbfd248b3ed82f6b31dd0337c2aae814

@kannon92
Copy link
Contributor

/assign @tenzen-y

@kannon92
Copy link
Contributor

/assign @alculquicondor

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0c5740d into main Mar 11, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 11, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/jobset-0.4.0 branch March 11, 2024 18:23
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.3.2 to 0.4.0.
- [Release notes](https://github.com/kubernetes-sigs/jobset/releases)
- [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/jobset@v0.3.2...v0.4.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/jobset
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants