Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand kubectl direct watching to support heterogeneous use cases #6505

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Jan 8, 2021

This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes #6504

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #6505 (084ccb3) into master (c38961b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6505   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files          86       86           
  Lines        2702     2702           
  Branches      673      673           
=======================================
  Hits         1670     1670           
  Misses        787      787           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c38961b...060564a. Read the comment docs.

@starpit starpit force-pushed the hetereogeneous-watch branch 3 times, most recently from f3a6863 to 13e3975 Compare January 8, 2021 12:55
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
@starpit starpit merged commit 8df1ad3 into kubernetes-sigs:master Jan 8, 2021
@starpit starpit deleted the hetereogeneous-watch branch January 8, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand kubectl direct watching to support heterogeneous use cases
1 participant