Add missing error handling for --load-restrictor completion

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
kubernetes-sigs · Nov 21, 2023 · 72dd179 · 72dd179
1 parent 7228a28
commit 72dd179
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/kustomize/commands/build/build.go b/kustomize/commands/build/build.go
@@ -100,14 +100,18 @@ func NewCmdBuild(
 			return err
 		},
 	}
+
 	AddFlagOutputPath(cmd.Flags())
 	AddFunctionBasicsFlags(cmd.Flags())
 	AddFlagLoadRestrictor(cmd.Flags())
-	AddFlagLoadRestrictorCompletion(cmd)
 	AddFlagEnablePlugins(cmd.Flags())
 	AddFlagReorderOutput(cmd.Flags())
 	AddFlagEnableManagedbyLabel(cmd.Flags())
 
+	if err := AddFlagLoadRestrictorCompletion(cmd); err != nil {
+		log.Fatalf("Error adding completion for flag '--load-restrictor': %v", err)
+	}
+
 	msg := "Error marking flag '%s' as deprecated: %v"
 	err := cmd.Flags().MarkDeprecated(flagReorderOutputName,
 		"use the new 'sortOptions' field in kustomization.yaml instead.")

diff --git a/kustomize/commands/build/flagloadrestrictor.go b/kustomize/commands/build/flagloadrestrictor.go
@@ -24,8 +24,8 @@ func AddFlagLoadRestrictor(set *pflag.FlagSet) {
 			"relocatability of the kustomization.")
 }
 
-func AddFlagLoadRestrictorCompletion(cmd *cobra.Command) {
-	cmd.RegisterFlagCompletionFunc(flagLoadRestrictorName, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+func AddFlagLoadRestrictorCompletion(cmd *cobra.Command) error {
+	return cmd.RegisterFlagCompletionFunc(flagLoadRestrictorName, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return []string{
 			types.LoadRestrictionsNone.String(),
 			types.LoadRestrictionsRootOnly.String(),