Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5449: add release automation #5520

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

5449: add release automation #5520

wants to merge 23 commits into from

Conversation

antoooks
Copy link
Contributor

@antoooks antoooks commented Jan 28, 2024 •
edited

  • Add github workflow for kyaml, cmd/config, api, and kustomize
  • Revise script to support release automation
  • Revise gorepomod to support release automation
  • Add deprecation and other necessary comments
  • Add trim to handle CRLF upon semver.Parse()

Addresses #5449 and #5526

@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @antoooks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antoooks
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from e77082a to 8d6a252 Compare February 12, 2024 14:54
@antoooks antoooks mentioned this pull request Feb 19, 2024
Open
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from 4af5886 to 462f040 Compare May 29, 2024 16:03
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 29, 2024
koba1t and others added 13 commits May 31, 2024 00:38
@koba1t @antoooks
Update api to v0.17.2
9db8ed3
@koba1t @antoooks
Back to development mode; unpin the modules
c0dd45d
@colinodell @antoooks
fix: always show accumulation errors (kubernetes-sigs#5693)
0626baf 
* fix: always show accumulation errors if the resource was successfully loaded as a base

* chore: regression test

* chore: fix lint violations
@stormqueen1990 @antoooks
chore: add deprecation comment to commonLabels
870edf4 
`commonLabels` is deprecated, but the field did not have a deprecation comment,
like other fields do. Add the deprecation comment, as some IDEs use that as a
guideline to show a strikethrough in the field names (and to follow the pattern
of other deprecated fields).
@antoooks
add github workflow
0717aed
@antoooks
make create-release.sh work with CI
fd53cb0
@antoooks
add create release branch script, gh workflow triggers, gh workflow p…
68fa5de 
…ermissions, and release branch check
@antoooks
make gorepomod release work with automation and refactor ci steps
471c497
@antoooks
change how create-release parameter works
11d73ee
@antoooks
fix workflow
6c4aa28
@antoooks
split build-kustomize-libarry from create-release
69b00c6
@antoooks
fix tagging logic
8f74a33
@antoooks
add testing, add GetCurrentVersionFromHead
9f11c73
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from 2a524de to d9a1e83 Compare May 30, 2024 16:40
@antoooks antoooks changed the title draft: 5449 add release automation 5449 add release automation May 30, 2024
@antoooks antoooks changed the title 5449 add release automation 5449: add release automation May 30, 2024
@antoooks antoooks changed the title 5449: add release automation draft: 5449: add release automation May 30, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from e797984 to 749648b Compare May 30, 2024 18:22
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from c0d33f5 to e90f6d8 Compare May 30, 2024 18:23
@antoooks antoooks changed the title draft: 5449: add release automation 5449: add release automation May 30, 2024
@antoooks
Copy link
Contributor Author

@koba1t this is ready for review.

However, I don't know why the last release changes and some other changes got carried over into my PR, I'm sure have rebased it correctly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t Awaiting requested review from koba1t

@ncapps ncapps Awaiting requested review from ncapps

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@antoooks @k8s-ci-robot @koba1t @colinodell @stormqueen1990