Use a local test server instead of example.com #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @koba1t |
|
/lgtm
Perhaps we should resort to using an API mocker (like wiremock) to respond
something predictable instead.
|
k8s-ci-robot
added
the
lgtm
|
@karlkfi looks like it's failing tests because the address is returning HTTP status code 404 now 😅 |
karlkfi
force-pushed
the
karl-example-500
branch
from
057b69d
to
b6245c6
Compare
k8s-ci-robot
added
size/L
karlkfi
changed the title
|
Replaced with a local test server. |
karlkfi
force-pushed
the
karl-example-500
branch
from
b6245c6
to
38ad0b9
Compare
k8s-ci-robot
added
size/M
karlkfi
force-pushed
the
karl-example-500
branch
from
38ad0b9
to
593ffc8
Compare
karlkfi
force-pushed
the
karl-example-500
branch
from
593ffc8
to
9db92fd
Compare
|
Tests passed |
k8s-ci-robot
added
the
lgtm
|
Thanks @karlkfi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example.com was returning 500 for a while instead of 404 and causing the tests to fail.
So use a local test server instead.