better example for helm mountOptions #202

TiloGit · 2022-05-17T18:42:56Z

with current example --set nfs.mountOptions='nfsvers=3' I got error in helm:

Error: INSTALLATION FAILED: template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3
helm.go:84: [debug] template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3
INSTALLATION FAILED

this works better for me:
--set nfs.mountOptions={"nfsvers=3"}
or with other
--set nfs.mountOptions={"nolock\,nfsvers=3"}

linux-foundation-easycla · 2022-05-17T18:42:58Z

The committers listed above are authorized under a signed CLA.

✅ login: TiloGit (f017bea)

k8s-ci-robot · 2022-05-17T18:43:03Z

Welcome @TiloGit!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-17T18:43:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TiloGit
To complete the pull request process, please assign yonatankahana after the PR has been reviewed.
You can assign the PR to them by writing /assign @yonatankahana in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yonatankahana

hi @TiloGit,
mountOptions is an array.

using your solution (nfs.mountOptions={"nolock\,nfsvers=3"}) will produce:

mountOptions:
  - nolock,nfsvers=3

the correct way is to use nfs.mountOptions={"nolock"\,"nfsvers=3"} which will produce:

mountOptions:
  - nolock
  - nfsvers=3

TiloGit · 2022-05-26T18:11:35Z

@yonatankahana good call, I updated that.

yonatankahana · 2022-05-26T18:30:04Z

@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to 4.0.17?
any change to the helm chart require version release (unless, the helm release workflow will fail)

yonatankahana · 2022-05-26T18:37:40Z

charts/nfs-subdir-external-provisioner/README.md

@@ -69,7 +69,7 @@ The following tables lists the configurable parameters of this chart and their d
 | `leaderElection.enabled`            | Enables or disables leader election                                                                   | `true`                                                   |
 | `nfs.server`                        | Hostname of the NFS server (required)                                                                 | null (ip or hostname)                                    |
 | `nfs.path`                          | Basepath of the mount point to be used                                                                | `/nfs-storage`                                           |
-| `nfs.mountOptions`                  | Mount options (e.g. 'nfsvers=3')                                                                      | null                                                     |
+| `nfs.mountOptions`                  | Mount options (e.g. {"nolock"\,"nfsvers=3"})                                                          | null                                                     |


the \ disappears when file is rendered as you can see here: https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/27d772798deb510c105b05618686f35cf0cb71ec/charts/nfs-subdir-external-provisioner/README.md

you can just remove it i think

good call. needed double slash to escape.

i am wondering, the slash required only in helm --set because helm reads the comma as a separator between variables and the slash escapes it. but in this context maybe {"nolock","nfsvers=3"} without escape character is more fit... what do you think?

@TiloGit wdyt?

the install example list example with set. ; Can this be configured somehow else?
The values possible I would get from the Parameter list so if the set requires a escape the example should have it imho.

TiloGit · 2022-05-27T00:39:06Z

@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to 4.0.17? any change to the helm chart require version release (unless, the helm release workflow will fail)

done, do you need this also for readme changes?

yonatankahana · 2022-05-30T19:22:39Z

@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to 4.0.17? any change to the helm chart require version release (unless, the helm release workflow will fail)

done, do you need this also for readme changes?

yes, even though, personally, i don't consider it a version - the github action does detects it as a change and require version bump.
and it make some sense - the chart's README.md is part of the chart, its in the package, so... new version

charts/nfs-subdir-external-provisioner/README.md

better example for mountOptions readme with current example `--set nfs.mountOptions='nfsvers=3'` I got error in helm: ```console Error: INSTALLATION FAILED: template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3 helm.go:84: [debug] template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3 INSTALLATION FAILED bump helm version to 4.0.17 for readme change

TiloGit · 2022-05-30T20:00:06Z

@yonatankahana done, thanks for being patient with me.

TiloGit · 2022-06-14T21:14:24Z

@yonatankahana let me know if you need anything else from me.

TiloGit · 2022-07-15T21:52:05Z

@kmova and @wongma7 can you approve?

k8s-triage-robot · 2022-10-13T22:45:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

TiloGit · 2022-10-13T22:48:07Z

/remove-lifecycle stale

yonatankahana · 2022-11-24T13:44:06Z

@TiloGit
i still think its wrong to escape the comma there.
the escape is true for command line but the examples are usually jsons and in this context there is no need to escape the comma.

KyleSanderson · 2023-01-29T22:54:03Z

This field doesn't exist... I'm editing the deployment in the nfs block and it's erroring out.

# * <nil>: Invalid value: "The edited file failed validation": ValidationError(Deployment.spec.template.spec.volumes[0].nfs): unknown field "mountOptions" in io.k8s.api.core.v1.NFSVolumeSource

k8s-ci-robot · 2023-03-04T05:36:35Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2023-06-02T06:33:31Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

yonatankahana · 2023-06-02T22:24:44Z

/remove-lifecycle stale

k8s-triage-robot · 2024-01-19T17:58:02Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-18T18:07:12Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

KyleSanderson · 2024-02-19T21:48:22Z

/remove-lifecycle rotten

KyleSanderson · 2024-02-19T21:48:40Z

/remove-lifecycle stale

k8s-triage-robot · 2024-05-19T22:13:22Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 17, 2022

k8s-ci-robot requested review from kmova and wongma7 May 17, 2022 18:43

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 17, 2022

yonatankahana reviewed May 25, 2022

View reviewed changes

yonatankahana reviewed May 26, 2022

View reviewed changes

yonatankahana reviewed May 30, 2022

View reviewed changes

charts/nfs-subdir-external-provisioner/README.md Outdated Show resolved Hide resolved

TiloGit force-pushed the patch-1 branch from beadc21 to 875f932 Compare May 30, 2022 19:57

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 19, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

better example for helm mountOptions #202

better example for helm mountOptions #202

TiloGit commented May 17, 2022

linux-foundation-easycla bot commented May 17, 2022 •

edited

k8s-ci-robot commented May 17, 2022

k8s-ci-robot commented May 17, 2022

yonatankahana left a comment

TiloGit commented May 26, 2022

yonatankahana commented May 26, 2022

yonatankahana May 26, 2022

TiloGit May 27, 2022

yonatankahana May 30, 2022

yonatankahana Jun 1, 2022

TiloGit Jun 1, 2022

TiloGit commented May 27, 2022

yonatankahana commented May 30, 2022 •

edited

TiloGit commented May 30, 2022

TiloGit commented Jun 14, 2022

TiloGit commented Jul 15, 2022

k8s-triage-robot commented Oct 13, 2022

TiloGit commented Oct 13, 2022

yonatankahana commented Nov 24, 2022

KyleSanderson commented Jan 29, 2023

k8s-ci-robot commented Mar 4, 2023

k8s-triage-robot commented Jun 2, 2023

yonatankahana commented Jun 2, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

KyleSanderson commented Feb 19, 2024

KyleSanderson commented Feb 19, 2024

k8s-triage-robot commented May 19, 2024

better example for helm mountOptions #202

Are you sure you want to change the base?

better example for helm mountOptions #202

Conversation

TiloGit commented May 17, 2022

linux-foundation-easycla bot commented May 17, 2022 • edited

k8s-ci-robot commented May 17, 2022

k8s-ci-robot commented May 17, 2022

yonatankahana left a comment

Choose a reason for hiding this comment

TiloGit commented May 26, 2022

yonatankahana commented May 26, 2022

yonatankahana May 26, 2022

Choose a reason for hiding this comment

TiloGit May 27, 2022

Choose a reason for hiding this comment

yonatankahana May 30, 2022

Choose a reason for hiding this comment

yonatankahana Jun 1, 2022

Choose a reason for hiding this comment

TiloGit Jun 1, 2022

Choose a reason for hiding this comment

TiloGit commented May 27, 2022

yonatankahana commented May 30, 2022 • edited

TiloGit commented May 30, 2022

TiloGit commented Jun 14, 2022

TiloGit commented Jul 15, 2022

k8s-triage-robot commented Oct 13, 2022

TiloGit commented Oct 13, 2022

yonatankahana commented Nov 24, 2022

KyleSanderson commented Jan 29, 2023

k8s-ci-robot commented Mar 4, 2023

k8s-triage-robot commented Jun 2, 2023

yonatankahana commented Jun 2, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

KyleSanderson commented Feb 19, 2024

KyleSanderson commented Feb 19, 2024

k8s-triage-robot commented May 19, 2024

linux-foundation-easycla bot commented May 17, 2022 •

edited

yonatankahana commented May 30, 2022 •

edited