-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivoting to new operator implementation #232
Pivoting to new operator implementation #232
Conversation
Starting from this commit, operator will use the new controller implementation. The old implementation code will be deleted in the subsequent PRs
/assign @marquiz |
Thanks @yevgeny-shnaidman for the PR. I'll check it in detail a bit later. First question (after a 30s skim-through): are the logger changes related/dependent on this (or could they be a separate PR)? |
They are dependent on switching to the new controller. Unless we do them, we will see some warnings in the manager log |
Kinda useless nitting, but where do we get warnings? Looking at the PR now we only change logger in main.go which shouldn't affect any other parts of the codebase 🧐 So it looks to me like the logger changes could/should be just a separate PR. |
We get the warning in the manager log, but those warnings are coming from the controller-runtime code. I can split this PR into 2 ( first the actual pivot and then the logging PR), but i wanted to keep it altogether so that after this PR the operator can be seen deployed and running with logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yevgeny-shnaidman. I'm good to merge this as is
/assign @ArangoGutierrez
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @ArangoGutierrez |
Sorry I was traveling last week, will review this one this week |
/ping @ArangoGutierrez |
ping @ArangoGutierrez |
/lgtm |
Starting from this commit, operator will use the new controller implementation. The old implementation code will be deleted in the subsequent PRs