Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump k8s deps to v1.26.4 #1254

Merged
merged 7 commits into from May 19, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented May 9, 2023

/kind feature

  • bump k8s deps to v1.26.4
  • bump otel to v0.38.1 and update metrics
  • drop the total_ prefix from the metric name
  • collect metrics as part of CI
  • validate metrics as part of CI

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2023
@aramase aramase changed the title chore: bump k8s deps to v1.26.4 [WIP] chore: bump k8s deps to v1.26.4 May 9, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage: 30.08% and project coverage change: -1.03 ⚠️

Comparison is base (3506170) 55.89% compared to head (4e853c9) 54.86%.

❗ Current head 4e853c9 differs from pull request most recent head 836b1c4. Consider uploading reports for the commit 836b1c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   55.89%   54.86%   -1.03%     
==========================================
  Files          22       22              
  Lines        2258     2324      +66     
==========================================
+ Hits         1262     1275      +13     
- Misses        877      927      +50     
- Partials      119      122       +3     
Impacted Files Coverage Δ
pkg/secrets-store/secrets-store.go 30.30% <0.00%> (-5.42%) ⬇️
pkg/secrets-store/stats_reporter.go 0.00% <0.00%> (ø)
pkg/rotation/reconciler.go 45.00% <37.50%> (-0.44%) ⬇️
pkg/rotation/stats_reporter.go 75.00% <75.00%> (-25.00%) ⬇️
pkg/secrets-store/nodeserver.go 48.01% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aramase aramase force-pushed the aramase/c/v1.26.4 branch 3 times, most recently from 2d77a6e to f7cc100 Compare May 10, 2023 23:04
@aramase
Copy link
Member Author

aramase commented May 10, 2023

/cc @tam7t

@aramase
Copy link
Member Author

aramase commented May 10, 2023

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 10, 2023
@aramase
Copy link
Member Author

aramase commented May 10, 2023

121699b is a breaking change. Added more description in the commit.

@aramase aramase changed the title [WIP] chore: bump k8s deps to v1.26.4 chore: bump k8s deps to v1.26.4 May 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@tam7t
Copy link
Contributor

tam7t commented May 14, 2023

/test pull-secrets-store-csi-driver-e2e-windows

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
For prometheus counters, by default they're appending _total if it's
monotonic counter. Removing the total_ prefix as it's redundant in the
name (xref: open-telemetry/opentelemetry-go#3360).
This is a breaking change.

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@tam7t
Copy link
Contributor

tam7t commented May 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6551fe2 into kubernetes-sigs:main May 19, 2023
26 checks passed
@aramase aramase deleted the aramase/c/v1.26.4 branch May 19, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants