Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kubernetes dependencies #1414

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Bump Kubernetes dependencies #1414

merged 1 commit into from
Mar 7, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 12, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This also updates controller-tools, controller-runtime as well as cert-manager, which rely on the Kubernetes bump.

Which issue(s) this PR fixes:

None

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated cert-manager to v1.11.0.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 12, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
This was referenced Jan 12, 2023
Closed
Closed
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023 •
edited

Codecov Report

Merging #1414 (c225b6b) into main (1a54e49) will decrease coverage by 0.19%.
The diff coverage is 7.54%.

❗ Current head c225b6b differs from pull request most recent head 97c9ca7. Consider uploading reports for the commit 97c9ca7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   44.17%   43.97%   -0.20%     
==========================================
  Files          50       50              
  Lines        5646     5671      +25     
==========================================
  Hits         2494     2494              
- Misses       3032     3057      +25     
  Partials      120      120

@saschagrunert
Copy link
Member Author

Alright this is strange:

Expected nil, but got: &errors.errorString{s:"command /usr/local/bin/kubectl create -f deploy/operator.yaml did not succeed: The CustomResourceDefinition \"securityprofilesoperatordaemons.security-profiles-operator.x-k8s.io\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[daemonResourceRequirements].properties[claims].items.x-kubernetes-map-type: Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set\n"}

@saschagrunert saschagrunert mentioned this pull request Jan 12, 2023
Closed
@saschagrunert
Copy link
Member Author

We have to wait for v1.26.1 to be able to upgrade: kubernetes/kubernetes#114617

@saschagrunert
Copy link
Member Author

We have to wait for kindest/node:v1.26.1 to be built.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2023
@saschagrunert
Copy link
Member Author

Still no kindest/node:v1.26.1 image out yet.

JAORMX
JAORMX approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚢

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2023
@saschagrunert
Copy link
Member Author

Ship it ship

Still waiting for kind (kubernetes-sigs/kind#3080).

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023
@saschagrunert saschagrunert mentioned this pull request Feb 27, 2023
Closed
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2023
@saschagrunert
Copy link
Member Author

Skipping the Kind update for now.

@saschagrunert
Copy link
Member Author

@kubernetes-sigs/security-profiles-operator-maintainers PTAL

@saschagrunert saschagrunert changed the title Bump Kubernetes dependencies WIP: Bump Kubernetes dependencies Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
@saschagrunert saschagrunert changed the title WIP: Bump Kubernetes dependencies Bump Kubernetes dependencies Mar 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2023
@saschagrunert
Kubernetes dependencies
59ecddd 
This also updates controller-tools, controller-runtime as well as
cert-manager, which rely on the Kubernetes bump.

Make `DaemonResourceRequirements` non `omitempty`.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Mar 7, 2023
Closed
@JAORMX
Copy link
Contributor

JAORMX commented Mar 7, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JAORMX,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 892ee33 into kubernetes-sigs:main Mar 7, 2023
@saschagrunert saschagrunert deleted the deps branch March 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

@ccojocar ccojocar Awaiting requested review from ccojocar

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@JAORMX JAORMX

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @codecov-commenter @JAORMX @k8s-ci-robot