Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gopkg.in/yaml.v3 #80

Closed
wants to merge 1 commit into from
Closed

Conversation

rhatdan
Copy link

@rhatdan rhatdan commented Jun 17, 2022

Trying to reduce the size of Podman by eliminating the need for v2 of
this library. This repo is one of the last v2 holdouts.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhatdan
To complete the pull request process, please assign liggitt after the PR has been reviewed.
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2022
Trying to reduce the size of Podman by eliminating the need for v2 of
this library. This repo is one of the last v2 holdouts.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2022
@dims
Copy link
Member

dims commented Jun 17, 2022

@rhatdan i wish it was as simple as that :)

#72

@liggitt
Copy link

liggitt commented Jun 17, 2022

yeah, thanks for the PR, but closing this as a duplicate of #61 (which itself is blocked on the compatibility issues with yaml.v3, and will likely be closed in favor of our own compatibilized version once it is added in #76)

/triage duplicate
/close

@k8s-ci-robot k8s-ci-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jun 17, 2022
@k8s-ci-robot
Copy link

@liggitt: Closed this PR.

In response to this:

yeah, thanks for the PR, but closing this as a duplicate of #61 (which itself is blocked on the compatibility issues with yaml.v3 and will likely be closed in favor of our own compatibilized version once it is added in #76

/triage duplicate
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Author

rhatdan commented Jun 17, 2022

Thanks, I thought the other one was held up for other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants