-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another valid container repository to our list. #680
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @JessMWalters. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DangerOnTheRanger @cheftako can you help us to get context here #168 , it seems this is duplicate |
Created #704 to cleanup the unused pkg directory. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JessMWalters The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
mrhohn is OOO till the 10th of June, is there someone else that can do the approval review? |
Can you please squash all the commits? |
Update gcpcredential.go Remove update from pkg file as it is obsolete
f41bbf7
to
0719edb
Compare
New changes are detected. LGTM label has been removed. |
There are valid docker repositories at "docker.UNIVERSE_NAME.goog" that are valid and we have had a request to add those to our list of repo urls.