Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored dependencies from v28.2 to v28.4 #694

Open
wants to merge 1 commit into
base: release-1.28
Choose a base branch
from

Conversation

cezarygerard
Copy link
Contributor

@cezarygerard cezarygerard commented May 17, 2024

Updated dependencies from v28.2 to v28.4
then I have run:

  • Update library to the desired version.
    ginko-test-package-version.env, go.mod, providers/go.mod, crd/go.mod and crd/hack/go.mod describe the required libraries. Update the version of each dependency to the desired Kubernetes release version. Run go mod tidy after update. First in crd/hack, then in crd and /providers, then in a root path.
    Run tools/update_vendor.sh

  • In WORKSPACE, update fetch_kube_release sha and version to the desired release version.
    Note: The current Kubernetes release is using sha512 hash while cloud-provider-gcp is using sha256. Re-sha with command sha256sum if needed. Use export KUBE_VERSION=v1.X.Y; tools/sha256_generator.sh to generate values automatically.

  • Update KUBE_GIT_VERSION in

    if [[ -n ${KUBE_GIT_VERSION-} ]] || KUBE_GIT_VERSION=$(echo "v1.18.0-alpha+${KUBE_GIT_COMMIT}"); then
    with the right tag.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cezarygerard
Once this PR has been reviewed and has the lgtm label, please assign mikedanese for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from aojea and sdmodi May 17, 2024 13:12
@jprzychodzen
Copy link
Contributor

@cezarygerard
Copy link
Contributor Author

/retest

@cezarygerard
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@code-elinka
Copy link

/test all

@k8s-ci-robot
Copy link
Contributor

@cezarygerard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloud-provider-gcp-verify-crds 736cdbf link true /test cloud-provider-gcp-verify-crds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants