[manila-csi-plugin] Fix error connecting to nfs plugin when using cluster proxy #1528
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @mdbooth. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
@gman0 ptal |
|
Build failed.
|
|
Build succeeded.
|
|
@Fedosin: Fedosin unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
/retest |
|
Thanks, @mdbooth ! |
k8s-ci-robot
added
the
lgtm
|
Let's see about the CI. |
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance |
|
@mdbooth: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance |
|
@ramineni: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance |
|
@ramineni: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 |
|
@ramineni: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build failed.
|
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19 |
|
@ramineni: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
lb-octaia job is disabled now. |
|
@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-lb-octavia In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 |
|
@Fedosin: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 |
|
@Fedosin: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ramineni Can you help us get this one in? We've got a downstream customer who needs it. Thanks! |
|
overriding 1.18-e2e-conformance , as no need for this PR and also would be removed in future on master branch |
|
@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@ramineni Thanks much! |
…ster proxy (kubernetes#1528) * Bump gRPC to v1.29.0 (kubernetes#1527) This bump is required to add support for grpc.WithNoProxy(). Note that bumping to v1.30.0 or newer causes a build failure in go.etcd.io/etcd/clientv3, described in etcd-io/etcd#11563. It is not possible to bump gRPC further until etcd v3.5 is released, which updates the relevant api uses. * [manila-csi-plugin] Ignore proxy connecting to CSI sockets (kubernetes#1527)
Which issue this PR fixes(if applicable):
fixes #1527
Special notes for reviewers:
This is very simple to reproduce on OpenShift by setting a cluster-wide proxy. See #1527 for reproducer steps.
Release note:
NOTE
A better fix would be to update gRPC to at least v1.34.0 which contains grpc/grpc-go#3890. This supports the unix protocol explicitly and never proxies it. However, due to our transitive dep on etcd clientv3 and etcd-io/etcd#11563 we are pinned to gRPC <= v1.30.0. The etcd 3.5 branch has finally bumped the gRPC version, but that is not released yet. None of the etcd stable branch tags contain a gRPC bump.
/cc @Fedosin