Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions for 1.30 #2584

Closed
wants to merge 1 commit into from
Closed

Bump versions for 1.30 #2584

wants to merge 1 commit into from

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Apr 25, 2024

What this PR does / why we need it:
Bumping versions for K8s 1.30.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2024
zetaab
zetaab approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 25, 2024

/hold

This needs #2581 first. Also k3s 1.30 is not yet released, so I'm sure this'll fail CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
zetaab
zetaab reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm actually worth of updating those helm chart maintainers first

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 25, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dulek / name: Michal Dulko (5f50a9e)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 25, 2024

/easycla

1 similar comment
@dulek
Copy link
Contributor Author

dulek commented Apr 25, 2024

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-csi-cinder-e2e-test 5f50a9e link true /test openstack-cloud-csi-cinder-e2e-test
openstack-cloud-controller-manager-e2e-test 5f50a9e link true /test openstack-cloud-controller-manager-e2e-test
openstack-cloud-csi-manila-e2e-test 5f50a9e link true /test openstack-cloud-csi-manila-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zetaab
Copy link
Member

zetaab commented May 4, 2024

@dulek can you rebase this as #2581 is merged already

@zetaab zetaab mentioned this pull request May 5, 2024
Merged
@zetaab
Copy link
Member

zetaab commented May 7, 2024

I will close this and rebase it in #2589

@zetaab zetaab closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dulek @k8s-ci-robot @zetaab