Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] fix PDB templating and add support for HPA, pod affinity etc #8581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enneitex
Copy link
Contributor

@enneitex enneitex commented Dec 29, 2023

Fixes #8340
Fixes #8137

  • Updated podDisruptionBudget template file and splitted it in two files, so we can create a PDB per deployment instead of one for the whole app.
  • Removed app.scheduling.nodeSelector as it was breaking tempalting when it was defined but not api.nodeSelector
  • Added variables to set affinity, tolerations, replicas, topologySpreadConstraints and HorizontalPodAutoscaler for WEB and API deployments
  • moved replicas from app.scaling to each component so we can set different replica for WEB and API deployments

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enneitex
Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart: Add affinity and tolerations to api and web deployments Helm Chart v7.0.3 is Broken
2 participants