feat(chart): Set GOMAXPROCS and GOMEMLIMIT environment variables
#8989
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
floreks
changed the title
GOMAXPROCS and GOMEMLIMIT environment variablesGOMAXPROCS and GOMEMLIMIT environment variables
floreks
changed the title
GOMAXPROCS and GOMEMLIMIT environment variablesGOMAXPROCS and GOMEMLIMIT environment variables
floreks
approved these changes
May 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, jnoordsij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
floreks
added
the
kind/feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8989 +/- ##
==========================================
- Coverage 37.20% 37.19% -0.01%
==========================================
Files 255 255
Lines 11156 11156
Branches 157 158 +1
==========================================
- Hits 4151 4150 -1
- Misses 6755 6756 +1
Partials 250 250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
GOMAXPROCSandGOMEMLIMITenvironment variables based on container resources.The
resourceFieldRefis a very specific Kubernetes directive that is created specifically for passing resource-related values, which rounds up the CPU value to the nearest whole number (e.g. 250m to 1) and passes the memory as a numeric value; so64Miwould result in the environment variable being set to67108864. This by design makes it completely compatible with Go's API.An example is documented within Kubernetes documentation itself: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-container-fields-as-values-for-environment-variables.
Inspired by traefik/traefik-helm-chart#1029, this should reduce potential CPU throttling and OOMKills on containers.
This also replaces a reference to
.Values.web.containers.envin themetrics-scraperdeployment, which I assumed to be an unintented faulty value.