Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KEP 3157 (watch-list) for milestone 1.31 #4605

Merged
merged 2 commits into from May 23, 2024
Merged

Update KEP 3157 (watch-list) for milestone 1.31 #4605

merged 2 commits into from May 23, 2024

Conversation

p0lyn0mial
Copy link
Contributor

  • One-line PR description: Update KEP 3157 (watch-list) for milestone 1.31
  • Other comments: N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2024
@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k
/cc @wojtek-t

@wojtek-t
Copy link
Member

@p0lyn0mial - can we combine this PR with the other one updating criteria?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@p0lyn0mial p0lyn0mial mentioned this pull request May 7, 2024
Closed
@p0lyn0mial
Copy link
Contributor Author

@p0lyn0mial - can we combine this PR with the other one updating criteria?

done

sftim
sftim reviewed May 7, 2024
View reviewed changes
keps/sig-api-machinery/3157-watch-list/kep.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# The following PRR answers are required at beta release
metrics:
  - my_feature_metric

I think this needs a tweak for PRR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thx, interestingly i haven't found a kep that would provide info in this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my query was broken, there are KEPs that use this field, e.g.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/4420-retry-generate-name/kep.yaml

https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/2436-controller-manager-leader-migration/kep.yaml

deads2k
deads2k reviewed May 7, 2024
View reviewed changes
keps/sig-api-machinery/3157-watch-list/README.md Outdated
- [Switch](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go#L416)
the `storage/cacher` to use streaming directly from etcd
(This will also allow us to [remove](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/client-go/tools/cache/reflector.go#L110) the `reflector.UseWatchList` field).
- Make **list** calls expensive in APF.
Copy link
Contributor

@deads2k deads2k May 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be post GA. clients need time to update. but I agree in principle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to capture it as a new section Post-GA (will not match the template) or will it be okay to update the text ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add "Post-GA' section for this

Copy link
Contributor

@deads2k deads2k May 21, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add "Post-GA' section for this

Yes. Spoke with Lucasz this morning and explained that we need to ensure the fallback list behavior works until all supported releases have streaming list GA and we have turned on "lock to on". After that we can increase the cost of regular list calls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks, pushed.

sftim
sftim reviewed May 16, 2024
View reviewed changes
keps/sig-api-machinery/3157-watch-list/kep.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  - name: WatchListClient (the actual name might be different because it hasn't been added yet))

Is that still true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is correct - https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/features/known_features.go#L39

In general, we are aware that this KEP is outdated and we are planing to change it to reflect the actual implementation.

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@deads2k
Copy link
Contributor

deads2k commented May 23, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit e9ce75a into kubernetes:master May 23, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@sftim sftim sftim left review comments

@apelisse apelisse Awaiting requested review from apelisse

@jpbetz jpbetz Awaiting requested review from jpbetz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@deads2k deads2k

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @wojtek-t @deads2k @k8s-ci-robot @sftim