Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4004: promote stage to beta #4625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HirazawaUi
Copy link
Contributor

  • One-line PR description: Promote the stage of KEP to beta.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels May 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
@HirazawaUi
Copy link
Contributor Author

/assign @danwinship

@HirazawaUi HirazawaUi force-pushed the promote-DisableNodeKubeProxyVersion-to-beta branch from 1b0a0c6 to 1568303 Compare May 9, 2024 16:12
@wojtek-t wojtek-t self-assigned this May 10, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to KEP reviewers: I'd have named this gate LegacyNodeKubeProxyVersion or NodeKubeProxyVersion. I'ts feasible that we still can (by changing the feature gate name for beta)

Even when we intend to disable something, the feature gate is typically named after the thing we want to disable. It means in docs we don't ask people to, eg, “enable DisableNodeKubeProxyVersion” or “enable the DisableNodeKubeProxyVersion feature gate” - both of those jar, but the first one especially so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we ever do that? (Change a feature gate name between alpha and beta?)

If it matters, we're pretty sure no one will actually need to set this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed gate names, but I wouldn't think it's worth it here.

It was more feedback about how to review future KEPs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we ever do that? (Change a feature gate name between alpha and beta?)

If it matters, we're pretty sure no one will actually need to set this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship, HirazawaUi
Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants