Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Jeffwan as a wg serving chair #6782

Merged
merged 1 commit into from May 23, 2024
Merged

added Jeffwan as a wg serving chair #6782

merged 1 commit into from May 23, 2024
+6 −0

Conversation

SergeyKanzhelev
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2024
@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label May 3, 2024
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels May 3, 2024
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request May 3, 2024
Open
17 tasks
terrytangyuan
terrytangyuan approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have you! @Jeffwan

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
dims
dims reviewed May 4, 2024
View reviewed changes
groups/groups.yaml Outdated
@@ -153,3 +153,4 @@ groups:
- xandergrzyw@gmail.com # CoCC
- xingyang105@gmail.com
- ynli@google.com
- wg-serving-leads@kubernetes.io # WG Serving leads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we have not been doing this. So can we please not add this line here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I should include people one by one? Is there any troubles with group memberships? I saw it being used in some other groups

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this list already have an example:

k8s.io/groups/groups.yaml

Line 51 in 5c1916e

- community@kubernetes.io

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean that up @SergeyKanzhelev. must have missed that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Just for my education, what is wrong with aliases in this list?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dims , can we move forward with this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's please drop wg-serving-leads@kubernetes.io from this list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now actually fixed it. My excuse it that I trusted VSCode UI for PR editing, but it left the change unmerged. Sorry about it

@dims
Copy link
Member

dims commented May 4, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2024
@ArangoGutierrez
Copy link
Contributor

Any update here?

@k8s-ci-robot k8s-ci-robot added wg/serving Categorizes an issue or PR as relevant to WG Serving. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 16, 2024
ArangoGutierrez
ArangoGutierrez approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@ArangoGutierrez
Copy link
Contributor

/assign bentheelder

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, BenTheElder, SergeyKanzhelev, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@Jeffwan
Copy link

Jeffwan commented May 23, 2024

@dims do you think we can cancel the hold for the PR now?

@dims
Copy link
Member

dims commented May 23, 2024

/hold cancel

thanks @SergeyKanzhelev @Jeffwan

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 35a51dc into kubernetes:main May 23, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@SergeyKanzhelev SergeyKanzhelev deleted the AddJeffwan branch May 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Assignees

@BenTheElder BenTheElder

@terrytangyuan terrytangyuan

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/serving Categorizes an issue or PR as relevant to WG Serving.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SergeyKanzhelev @dims @ArangoGutierrez @BenTheElder @k8s-ci-robot @Jeffwan @terrytangyuan