Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gce: when using only ipv6, we don't need a CNI to set up the network. #15930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gce: when using only ipv6, we don't need a CNI to set up the network. #15930

wants to merge 1 commit into from

Conversation

justinsb
Copy link
Member

IPv6 addresses are "real" addresses, and don't need any further
configuration on GCE.

@justinsb
gce: when using only ipv6, we don't need a CNI to set up the network.
fdd0614 
IPv6 addresses are "real" addresses, and don't need any further
configuration on GCE.
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

/hold as @aojea suggested this might be done for us in the latest CCM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
johngmyers
johngmyers reviewed Sep 19, 2023
View reviewed changes
cmd/kops-controller/controllers/gceipam.go
if condition.Type == "NetworkUnavailable" {
if condition.Status == corev1.ConditionTrue {
newCondition := metav1.Condition{
Message: "Node has IPv6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Message: "Node has IPv6",
Message: "Node is IPv6-only",

@johngmyers
Copy link
Member

Unrelated to this PR, but consider updating the GCP node identifier to use the non-legacy interface.

aojea
aojea reviewed Sep 19, 2023
View reviewed changes
cmd/kops-controller/controllers/gceipam.go
@@ -139,6 +147,46 @@ func (r *GCEIPAMReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
}
}

if len(node.Spec.PodCIDRs) != 0 {
Copy link
Member

@aojea aojea Sep 19, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make this simpler , this field is already validated in the apiserver https://github.com/kubernetes/kubernetes/blob/54d42e6a658f84ea66593d3107f41db6931a5fbf/pkg/apis/core/validation/validation.go#L4247-L4281 , so if there are two values , they are ipv4 and ipv6

Suggested change
if len(node.Spec.PodCIDRs) != 0 {
netutils "k8s.io/utils/net"
if len(node.Spec.PodCIDRs) != 1 {
return ctrl.Result{}, nil
}
if netutils.IsIPv4CIDR(node.Spec.PodCIDRs[0]) {
return ctrl.Result{}, nil
}
...
patch condition here to unset NetworkUnavailable
...

@aojea
Copy link
Member

aojea commented Sep 19, 2023

/hold as @aojea suggested this might be done for us in the latest CCM

/hold cancel

the cloud provider gcp will take some time because the ipam code changes are not straightforward, this ipam here is pretty neat and simple and will allow us to iterate faster

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-verify-golangci-lint fdd0614 link true /test pull-kops-verify-golangci-lint
pull-kops-e2e-k8s-gce-ipalias fdd0614 link true /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-aws-calico fdd0614 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-kubernetes-e2e-ubuntu-gce-build fdd0614 link true /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@aojea aojea aojea left review comments

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
area/kops-controller cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinsb @k8s-ci-robot @johngmyers @aojea @k8s-triage-robot