New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Use droplet ID for node names in DO #16004
base: master
Are you sure you want to change the base?
Conversation
This matches GCE and AWS and matches an assumption in failing e2e tests that node names match their hostname Signed-off-by: Peter Rifel <pgrifel@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-kubernetes-do-dns-none |
/test pull-kops-e2e-kubernetes-do-dns-none |
/test pull-kops-e2e-kubernetes-do-dns-none |
Whats the advantage of using the droplet ID over the IP address for the node name? I suppose it matches AWS' instance ID node names, any other benefits? |
I am also curious if this way it will pass that failing test. |
@hakman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/cc @rifelpet