chore(karpenter): upgrade karpenter to v0.32.6 #16327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
moshevayner
force-pushed
the
16311-upgrade-karpenter-0.32.6
branch
from
60e2ba7
to
bee8cb3
Compare
|
/test all |
hakman
requested changes
Feb 8, 2024
Comment on lines
1609
to
1625
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux | ||
| - key: karpenter.sh/provisioner-name | ||
| operator: DoesNotExist | ||
| - key: node-role.kubernetes.io/control-plane | ||
| operator: Exists | ||
| - matchExpressions: | ||
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux | ||
| - key: karpenter.sh/provisioner-name | ||
| - key: karpenter.sh/nodepool | ||
| operator: DoesNotExist | ||
| - key: node-role.kubernetes.io/master | ||
| operator: Exists |
Comment on lines
1643
to
1646
| - key: node-role.kubernetes.io/master | ||
| operator: Exists | ||
| - key: node-role.kubernetes.io/control-plane | ||
| operator: Exists |
There was a problem hiding this comment.
Yeah, that makes sense. I must've overlooked those, and that could make sense as to why the tests are failing.
Let me give that a try.
Thanks for catching that!
moshevayner
force-pushed
the
16311-upgrade-karpenter-0.32.6
branch
from
bee8cb3
to
7b7400c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
moshevayner
force-pushed
the
16311-upgrade-karpenter-0.32.6
branch
from
7b7400c
to
3a76e1f
Compare
|
/retest |
|
@moshevayner: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I guess CRDs need updating: |
moshevayner
changed the base branch from
master
to
dependencies/update-1658470204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumps karpenter version to 0.32.6
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):fixes #16311
Special notes for your reviewer:
Release page