Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating google.golang.org/api (to version v0.45.0) #102267

Closed
wants to merge 0 commits into from

Conversation

basantsa1989
Copy link
Contributor

Updating to latest google.golang.org/api (version v0.45.0)

/kind design
/kind api-change

Commands run:

##Commit ID points to the commit that updates the API to version v0.45.0
hack/pin-dependency.sh github.com/GoogleCloudPlatform/k8s-cloud-provider 2e28a39f7bad9f4e3b88ac701235761d4b80d4b0
hack/update-vendor.sh

##Commit ID points to the commit tagging the v0.45.0 release
hack/pin-dependency.sh google.golang.org/api de9f25cba16a59e6a62c6b97478882f5392143f5
hack/update-vendor.sh
hack/verify-vendor.sh

@k8s-ci-robot
Copy link
Contributor

@basantsa1989: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @basantsa1989. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from adtac, andrewsykim and a team May 24, 2021 22:00
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2021
@MrHohn
Copy link
Member

MrHohn commented May 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2021
@k8s-ci-robot
Copy link
Contributor

@basantsa1989: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-dependencies f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-dependencies
pull-kubernetes-node-e2e-containerd f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-unit f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-unit
pull-kubernetes-verify f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce-100-performance f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-ubuntu-containerd f01eeba2a95ca23a6dda4c9576835245d31b5813 link /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot
Copy link
Contributor

@basantsa1989: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2021
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 25, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage May 26, 2021
@logicalhan
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jun 2, 2021
@basantsa1989 basantsa1989 marked this pull request as draft June 2, 2021 17:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2021
@dims
Copy link
Member

dims commented Jun 8, 2021

@basantsa1989 need help doing this?

@basantsa1989
Copy link
Contributor Author

basantsa1989 commented Jun 8, 2021

@basantsa1989 need help doing this?

@dims thanks a lot for offering to help!
My goal here is to update google.golang.org/api version. While updating the transitive dependencies, I had to update grpc version and that led to this error:

warning: ignoring symlink /usr/local/google/home/basantsa/go/src/k8s.io/kubernetes/cluster/gce/custom
warning: ignoring symlink /usr/local/google/home/basantsa/go/src/k8s.io/kubernetes/cluster/gce/ubuntu
go: finding module for package google.golang.org/grpc/examples/helloworld/helloworld
go: finding module for package google.golang.org/grpc/naming
go: downloading google.golang.org/grpc/examples v0.0.0-20210526223527-2de42fcbbce3
go: found google.golang.org/grpc/examples/helloworld/helloworld in google.golang.org/grpc/examples v0.0.0-20210526223527-2de42fcbbce3
warning: ignoring symlink /usr/local/google/home/basantsa/go/src/k8s.io/kubernetes/cluster/gce/cos
warning: ignoring symlink /usr/local/google/home/basantsa/go/src/k8s.io/kubernetes/cluster/gce/custom
warning: ignoring symlink /usr/local/google/home/basantsa/go/src/k8s.io/kubernetes/cluster/gce/ubuntu
go: finding module for package google.golang.org/grpc/naming
k8s.io/kubernetes/pkg/registry/registrytest imports
        k8s.io/apiserver/pkg/storage/etcd3/testing imports
        go.etcd.io/etcd/integration imports
        go.etcd.io/etcd/proxy/grpcproxy imports
        google.golang.org/grpc/naming: module google.golang.org/grpc@latest found (v1.38.0, replaced by google.golang.org/grpc@v1.37.0), but does not contain package google.golang.org/grpc/naming

Looks like I have to wait till etcd, grpc dependencies are fixed. This seems to be a known issue: etcd-io/etcd#12124

I need to wait for this PR to get in: #100488

Please let me know if I am missing anything.

@liggitt
Copy link
Member

liggitt commented Jun 16, 2021

grpc update is merged, this should be able to be rebased now

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: basantsa1989

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@basantsa1989
Copy link
Contributor Author

grpc update is merged, this should be able to be rebased now

Thanks @liggitt !
There were too many changes. Closed this and opened a new PR: #102926

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants