New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating google.golang.org/api (to version v0.45.0) #102267
Conversation
@basantsa1989: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @basantsa1989. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@basantsa1989: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
@basantsa1989: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-sig api-machinery |
/remove-sig instrumentation |
@basantsa1989 need help doing this? |
@dims thanks a lot for offering to help!
Looks like I have to wait till etcd, grpc dependencies are fixed. This seems to be a known issue: etcd-io/etcd#12124 I need to wait for this PR to get in: #100488 Please let me know if I am missing anything. |
grpc update is merged, this should be able to be rebased now |
f01eeba
to
4d2757b
Compare
4d2757b
to
3464112
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: basantsa1989 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
Updating to latest google.golang.org/api (version v0.45.0)
/kind design
/kind api-change
Commands run:
##Commit ID points to the commit that updates the API to version v0.45.0
hack/pin-dependency.sh github.com/GoogleCloudPlatform/k8s-cloud-provider 2e28a39f7bad9f4e3b88ac701235761d4b80d4b0
hack/update-vendor.sh
##Commit ID points to the commit tagging the v0.45.0 release
hack/pin-dependency.sh google.golang.org/api de9f25cba16a59e6a62c6b97478882f5392143f5
hack/update-vendor.sh
hack/verify-vendor.sh