fix 'y' to true when YAML decode to JSON

[CaoDonghui123]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #102308

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[wzshiming]

I think it is necessary to consider as a whole, patch this piece of logic separately and introduce new dependencies. I don't think this is a good modification.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CaoDonghui123
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS
• staging/src/k8s.io/apimachinery/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@CaoDonghui123: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-integration	e5e17ea	link	/test pull-kubernetes-integration
pull-kubernetes-conformance-kind-ga-only-parallel	e5e17ea	link	/test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-e2e-kind	e5e17ea	link	/test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6	e5e17ea	link	/test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-unit	e5e17ea	link	/test pull-kubernetes-unit
pull-kubernetes-e2e-gce-ubuntu-containerd	e5e17ea	link	/test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fedebongio]

/assign @roycaihw
/cc @lavalamp @liggitt since there is a version bump of yaml decoder
/triage accepted

[k8s-ci-robot]

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: there, a, version, decoder, yaml, since, is, bump, of.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @roycaihw
/cc @lavalamp @liggitt since there is a version bump of yaml decoder
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lavalamp]

One does not simply increase the version of the yaml library... 😱

This appears to have broken many unit tests. Ideally we can fix the bug with a much more lightweight tweak.

[roycaihw]

$ kubectl apply -f crd.yaml -v=9
...
Request Body: {"apiVersion":"apiextensions.k8s.io/v1","kind":"CustomResourceDefinition","metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"apiextensions.k8s.io/v1\",\"kind\":\"CustomResourceDefinition\",\"metadata\":{\"annotations\":{},\"name\":\"tests.calci.io\"},\"spec\":{\"group\":\"calci.io\",\"names\":{\"kind\":\"Test\",\"plural\":\"tests\",\"shortNames\":[\"tt\"],\"singular\":\"test\"},\"scope\":\"Namespaced\",\"versions\":[{\"name\":\"v1\",\"schema\":{\"openAPIV3Schema\":{\"properties\":{\"spec\":{\"properties\":{\"operation\":{\"enum\":[\"ADD\",\"SUB\",\"DIV\",\"MUL\"],\"type\":\"string\"},\"true\":{\"type\":\"number\"},\"x\":{\"type\":\"number\"}},\"type\":\"object\"}},\"type\":\"object\"}},\"served\":true,\"storage\":true}]}}\n"},"name":"tests.calci.io"},"spec":{"group":"calci.io","names":{"kind":"Test","plural":"tests","shortNames":["tt"],"singular":"test"},"scope":"Namespaced","versions":[{"name":"v1","schema":{"openAPIV3Schema":{"properties":{"spec":{"properties":{"operation":{"enum":["ADD","SUB","DIV","MUL"],"type":"string"},"true":{"type":"number"},"x":{"type":"number"}},"type":"object"}},"type":"object"}},"served":true,"storage":true}]}}

so far it looks like the problem happened in kubectl when sending the request. Could you look into fixing kubectl instead?

[BenTheElder]

there's also: #78946 which is a bit broader.

[liggitt]

sigs.k8s.io/yaml uses json tags in structs for marshaling/unmarshaling, and does mechanical yaml-json conversion

gopkg.in/yaml.v3 expects yaml struct tags, which none of our API types have, so this switch will not work at all for API types.

[roycaihw]

the fundamental issue is #34146. It's unclear if someone will eventually pick it up

[roycaihw]

this is sigs.k8s.io/yaml. Kubernetes depends on the features that sigs.k8s.io/yaml implements on top of go-yaml. We cannot simply change sigs.k8s.io/yaml to go-yaml v3.

Please consider moving forward the go-yaml v3 conversation in sigs.k8s.io/yaml. Some background:

• Should this library move to yaml.v3 kubernetes-sigs/yaml#18
• use gopkg.in/laverya/yaml.v3 instead of gopkg.in/yaml.v2 kubernetes-sigs/yaml#26

/close

[k8s-ci-robot]

@roycaihw: Closed this PR.

In response to this:

this is sigs.k8s.io/yaml. Kubernetes depends on the features that sigs.k8s.io/yaml implements on top of go-yaml. We cannot simply change sigs.k8s.io/yaml to go-yaml v3.

Please consider moving forward the go-yaml v3 conversation in sigs.k8s.io/yaml. Some background:

• Should this library move to yaml.v3 kubernetes-sigs/yaml#18
• use gopkg.in/laverya/yaml.v3 instead of gopkg.in/yaml.v2 kubernetes-sigs/yaml#26

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.