Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade github.com/cespare/xxhash/v2 to v2.1.2 #105142

Merged
merged 2 commits into from Jan 20, 2022
Merged

upgrade github.com/cespare/xxhash/v2 to v2.1.2 #105142

merged 2 commits into from Jan 20, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 20, 2021

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Sep 20, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 20, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Sep 20, 2021

/cc dims
/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Sep 20, 2021

I don't understand why dependency-stats thinks this increased direct deps:

-	"directDependencies": 162,
+	"directDependencies": 163,

@RinkiyaKeDad

@liggitt
Copy link
Member

liggitt commented Sep 20, 2021

I don't understand why dependency-stats thinks this increased direct deps

oh, I guess we express a version opinion about this now that is newer than the single use in prometheus client_golang. This version should really be bumped in https://github.com/prometheus/client_golang, tested and released before bumping here

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jan 19, 2022 

-	"directDependencies": 159,
+	"directDependencies": 160,

Files /logs/artifacts/stats-base.json and /logs/artifacts/stats.json are identical.

Ready to review now.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2022
liggitt
liggitt reviewed Jan 19, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@pacoxu pacoxu marked this pull request as draft January 19, 2022 14:09
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2022
@pacoxu pacoxu marked this pull request as ready for review January 19, 2022 14:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-aks-engine-windows-containerd 8a4e660 link false /test pull-kubernetes-e2e-aks-engine-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu pacoxu mentioned this pull request Jan 20, 2022
Closed
@pacoxu pacoxu requested a review from liggitt January 20, 2022 08:22
@liggitt
Copy link
Member

liggitt commented Jan 20, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d0d428 into kubernetes:master Jan 20, 2022
SIG CLI automation moved this from In progress to Done Jan 20, 2022
SIG Auth Old automation moved this from In Progress to Closed / Done Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 20, 2022
@kolyshkin kolyshkin mentioned this pull request Jan 21, 2022
Closed
@kolyshkin
Copy link
Contributor

@pacoxu I think you need to fix your name in git config. The commits have

From: -e paco.xu@daocloud.io

which does not look right to me.

@pacoxu
Copy link
Member Author

pacoxu commented Jan 21, 2022

@kolyshkin Thanks for reminding me. It is a misconfiguration on my laptop.

@pacoxu pacoxu deleted the cespare-2.1.2 branch May 10, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@cheftako cheftako

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG CLI
Done
SIG Node PR Triage
Triage
SIG Auth Old
Closed / Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

cespare should update to v2.1.2
7 participants
@pacoxu @liggitt @caesarxuchao @cheftako @dims @k8s-ci-robot @kolyshkin