New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prometheus/client_golang to v1.12.2 #111909
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 18 07:40:11 UTC 2022. |
/assign @mborsz |
/assign @liggitt |
/lgtm |
/retest |
/triage accepted |
dependency update lgtm, are we exporting these by default or does that depend on activation in #111910? |
We're not, their export require additional options to be passed to Prometheus's Go collector that we add in |
/approve will merge once master reopens for 1.26 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bump prometheus/client_golang to v1.12.2 to be able to add more options to
NewGoCollector
, i.e. to be able to export more Golang-related metrics.Which issue(s) this PR fixes:
No issue is opened for that.
Special notes for your reviewer:
/sig instrumentation
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: