Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logtools to support verbosity Zero Check #112215

Closed
wants to merge 1 commit into from
Closed

update logtools to support verbosity Zero Check #112215

wants to merge 1 commit into from

Conversation

yangjunmyfm192085
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

as discussed in kubernetes-sigs/logtools#2 and #111708, we should add verbosity Zero Check in logtools

Which issue(s) this PR fixes:

Fixes #112206

Special notes for your reviewer:

Does this PR introduce a user-facing change?

"NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

"NONE"

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/dependency Issues or PRs related to dependency changes labels Sep 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from hwdef, SataQiu and a team September 3, 2022 01:19
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 3, 2022
@yangjunmyfm192085
Copy link
Contributor Author

/cc @pohly

@yangjunmyfm192085
Copy link
Contributor Author

/retest

pohly
pohly reviewed Sep 5, 2022
View reviewed changes
hack/tools/go.mod Outdated
@@ -11,7 +11,7 @@ require (
github.com/google/go-flow-levee v0.1.5
gotest.tools/gotestsum v1.6.4
honnef.co/go/tools v0.3.3
sigs.k8s.io/logtools v0.1.0
sigs.k8s.io/logtools v0.2.1-0.20220830112100-f68289b649a5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a formal release of logtools first. For that I am waiting for kubernetes-sigs/logtools#1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
yangjunmyfm192085
yangjunmyfm192085 commented Sep 21, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
only for test, don't merge

@yangjunmyfm192085 yangjunmyfm192085 force-pushed the addverbosityZeroCheck branch 2 times, most recently from 05ab708 to 13cda26 Compare September 21, 2022 14:16
@yangjunmyfm192085
Copy link
Contributor Author

/uncc hwdef

@k8s-ci-robot k8s-ci-robot removed the request for review from hwdef September 21, 2022 14:17
pohly
pohly suggested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I released logtools v0.3.0. Can you update Kubernetes to that tagged release?

@yangjunmyfm192085
Copy link
Contributor Author

I released logtools v0.3.0. Can you update Kubernetes to that tagged release?

ok, Let me update to v0.3.0.
But before that, I think we need to merge #112671 and #112672

yangjunmyfm192085
yangjunmyfm192085 commented Sep 30, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2022
@pohly
Copy link
Contributor

pohly commented Oct 1, 2022

We probably need a list of all pending PRs that address the issues found by this tool update. Here are some that I am aware of:

@logicalhan
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yangjunmyfm192085
Once this PR has been reviewed and has the lgtm label, please assign pwittrock for approval by writing /assign @pwittrock in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yangjunmyfm192085
yangjunmyfm192085 commented Jan 17, 2023
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2023 •
edited

@yangjunmyfm192085: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-verify 7587617 link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangjunmyfm192085
Copy link
Contributor Author

/cc @pohly logcheck will still check for errors.
I'll analyze it later

@pohly
Copy link
Contributor

pohly commented Jan 17, 2023

Oh, I had forgotten about this PR and did my own with the same logtools update.

The errors are keys in existing code that violate our guidelines and now trigger warnings. I fixed them in #115060.

@k8s-ci-robot
Copy link
Contributor

@yangjunmyfm192085: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
yangjunmyfm192085
yangjunmyfm192085 commented Jan 20, 2023
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Closed due to PR expiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-architecture] Dependency management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update logtools to support verbosity Zero Check
4 participants
@yangjunmyfm192085 @pohly @logicalhan @k8s-ci-robot