-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 #112584
Conversation
/triage accepted |
/priority important-soon |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After looking into the release note of v1.5.0 cobra, there are some interesting improvements.
|
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
/lgtm |
Originally filed by
Berchris Requiao <brneto@gmail.com>
in #112362What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix an issues where the
kubectl
completion script for older version ofzsh
was failing to correctly parse the output of the__complete
command.Which issue(s) this PR fixes:
Fixes #105587
Fixes #1254
Does this PR introduce a user-facing change?