Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google.golang.org/genproto #118269

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 26, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates to a version of google.golang.org/genproto with generic packages carved into submodules (googleapis/go-genproto#1012)

These still include a backreference to the root google.golang.org/genproto module, but only for a period of time while consumers are transitioning to the new isolated modules.

xref #113366

See googleapis/go-genproto#1015 for details on the timeline for completing the submodule isolation.

This increases the total number of dependencies in our graph because it updates to a cloud.google.com/go that carved out submodules for every API:

-Direct Dependencies: 205 
-Transitive Dependencies: 228 
-Total Dependencies: 277 
-Max Depth Of Dependencies: 23 
+Direct Dependencies: 209 
+Transitive Dependencies: 341 
+Total Dependencies: 390 
+Max Depth Of Dependencies: 17

That's unfortunate in the short-term, but does not actually increase the number of vendored/built dependencies significantly, and unblocks several other dependency updates. Once genproto rpc/api/bytestream packages drop the back-reference to the root genproto library on 2024-03-01, we can drop those dependencies from our graph.

Does this PR introduce a user-facing change?

NONE

/area code-organization
/assign @dims

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/code-organization Issues or PRs related to kubernetes code organization size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 26, 2023
@liggitt liggitt changed the title WIP - Update google.golang.org/genproto Update google.golang.org/genproto May 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@jpbetz
Copy link
Contributor

jpbetz commented May 26, 2023

Thanks @liggitt! We need badly to allow us to continue to bump to new versions of CEL. I appreciate all the work you did to coordinate with the genproto maintainers to set up firm plan that allows us to remove unneeded transitive deps long-term.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ae9143a6d876d1b65280b68c519f49d23e96d69

@liggitt
Copy link
Member Author

liggitt commented May 26, 2023

/hold
thanks for the review, wanted to give @dims a chance to review as well
unhold once that is done

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@liggitt
Copy link
Member Author

liggitt commented May 26, 2023

@dims
Copy link
Member

dims commented May 26, 2023

+100 to what @jpbetz said. Glad there is a firm plan to clear this debt we are picking up now.

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d05b79c into kubernetes:master May 26, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 26, 2023
@cici37
Copy link
Contributor

cici37 commented May 30, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2023
@liggitt liggitt deleted the genproto branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants