-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google.golang.org/genproto #118269
Conversation
Thanks @liggitt! We need badly to allow us to continue to bump to new versions of CEL. I appreciate all the work you did to coordinate with the genproto maintainers to set up firm plan that allows us to remove unneeded transitive deps long-term. /lgtm |
LGTM label has been added. Git tree hash: 6ae9143a6d876d1b65280b68c519f49d23e96d69
|
/hold |
/retest |
+100 to what @jpbetz said. Glad there is a firm plan to clear this debt we are picking up now. /approve |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates to a version of google.golang.org/genproto with generic packages carved into submodules (googleapis/go-genproto#1012)
These still include a backreference to the root google.golang.org/genproto module, but only for a period of time while consumers are transitioning to the new isolated modules.
xref #113366
See googleapis/go-genproto#1015 for details on the timeline for completing the submodule isolation.
This increases the total number of dependencies in our graph because it updates to a
cloud.google.com/go
that carved out submodules for every API:That's unfortunate in the short-term, but does not actually increase the number of vendored/built dependencies significantly, and unblocks several other dependency updates. Once genproto rpc/api/bytestream packages drop the back-reference to the root genproto library on 2024-03-01, we can drop those dependencies from our graph.
Does this PR introduce a user-facing change?
/area code-organization
/assign @dims