Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dependencies] update prometheus/client_golang v1.14.0 to v1.16.0 #118689

Merged
merged 1 commit into from Jun 18, 2023
Merged

[dependencies] update prometheus/client_golang v1.14.0 to v1.16.0 #118689

merged 1 commit into from Jun 18, 2023

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Jun 15, 2023 •
edited by dims

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR is supposed to update prometheus/client_golang v1.14.0 to v1.16.0

This PR picks up prometheus/client_golang#1278 which includes process start time in a header, which allows scraping clients to immediately start streaming and processing metrics rather than load the entire payload into memory first (since metrics are lexically ordered and process_start_time_seconds starts with a p and is therefore late in the payload.

Fixes # none

@bzsuni
update prometheus/client_golang v1.14.0 to v1.16.0
5aa5f1a 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @bzsuni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 15, 2023
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, apelisse and a team June 15, 2023 11:26
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 15, 2023
@dims
Copy link
Member

dims commented Jun 15, 2023

Minor bump in total/transitive deps .. but tolerable

/logs/artifacts /home/prow/go/src/k8s.io/kubernetes
go: downloading github.com/kubernetes-sigs/depstat v0.7.0
go: downloading github.com/spf13/cobra v1.1.1
go: downloading github.com/spf13/pflag v1.0.5
/home/prow/go/src/k8s.io/kubernetes
HEAD is now at f3c39434c56 Merge commit '5aa5f1abc9c9d83ccc34382ae2a8e0241ec1d866'
Switched to a new branch 'base'
--- /logs/artifacts/stats-base.txt	2023-06-15 16:36:10.578109828 +0000
+++ /logs/artifacts/stats.txt	2023-06-15 16:36:10.234110644 +0000
@@ -1,6 +1,6 @@
 Direct Dependencies: 210 
-Transitive Dependencies: 340 
-Total Dependencies: 389 
+Transitive Dependencies: 342 
+Total Dependencies: 391 
 Max Depth Of Dependencies: 17 
 All dependencies:
 
@@ -143,6 +143,8 @@
 github.com/Microsoft/hcsshim
 github.com/NYTimes/gziphandler
 github.com/a8m/tree
+github.com/alecthomas/kingpin/v2
+github.com/alecthomas/units
 github.com/antihax/optional
 github.com/antlr/antlr4/runtime/Go/antlr/v4
 github.com/armon/circbuf
@@ -321,6 +323,7 @@
 github.com/vishvananda/netns
 github.com/vmware/govmomi
 github.com/vmware/vmw-guestinfo
+github.com/xhit/go-str2duration
 github.com/xiang90/probing
 github.com/xlab/treeprint
 github.com/yuin/goldmark
@@ -370,7 +373,6 @@
 google.golang.org/genproto/googleapis/rpc
 google.golang.org/grpc
 google.golang.org/protobuf
-gopkg.in/alecthomas/kingpin.v2
 gopkg.in/check.v1
 gopkg.in/gcfg.v1
 gopkg.in/inf.v0

@dims
Copy link
Member

dims commented Jun 15, 2023 •
edited

/sig instrumentation

cc @dgrisonnet @brancz @logicalhan for any inputs

@dims
Copy link
Member

dims commented Jun 15, 2023 •
edited

Differences for the main go.mod updates are:

@logicalhan
Copy link
Member

Differences for the main go.mod updates are:

We need this bump actually. There is a new feature in the prometheus golang client which we require in our of our KEPs.

logicalhan
logicalhan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b52d4ea3affc5853e28e186ad9d92e3eedbb6c0f

@dims
Copy link
Member

dims commented Jun 15, 2023

@bzsuni @logicalhan can you please call out what the new functionality is in the PR body?

@logicalhan
Copy link
Member

@bzsuni @logicalhan can you please call out what the new functionality is in the PR body?

It includes this PR: prometheus/client_golang#1278 which includes process start time in a header, which allows scraping clients to immediately start streaming and processing metrics rather than load the entire payload into memory first (since metrics are lexically ordered and process_start_time_seconds starts with a p and is therefore late in the payload.

@logicalhan
Copy link
Member

I cannot modify the PR body, I do not have the perms.

@dims
Copy link
Member

dims commented Jun 15, 2023

@logicalhan i can take care of that. thanks!

@dims
Copy link
Member

dims commented Jun 15, 2023

/approve
/lgtm

@dgrisonnet
Copy link
Member

dgrisonnet commented Jun 15, 2023 •
edited

This is quite surprising that we can now bump prometheus/common, it used to be blocked by #113366 when we tried it before in #114943.

@logicalhan logicalhan mentioned this pull request Jun 15, 2023
Closed
31 tasks
@dims
Copy link
Member

dims commented Jun 15, 2023

/assign @thockin

(for api/ directory go.mod/sum updates)

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jun 16, 2023
thockin
thockin reviewed Jun 18, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see no vendor/... changes outside of prometheus, but investigated and it is OK.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims, logicalhan, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0004ce8 into kubernetes:master Jun 18, 2023
16 checks passed
SIG Node PR Triage automation moved this from Triage to Done Jun 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 18, 2023
This was referenced Jun 20, 2023
Closed
Closed
Merged
@dgrisonnet dgrisonnet mentioned this pull request Jun 29, 2023
Closed
3 tasks
@bzsuni bzsuni mentioned this pull request Oct 8, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@logicalhan logicalhan logicalhan approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@dims dims

@logicalhan logicalhan

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bzsuni @k8s-ci-robot @logicalhan @jiahuif @dims @dgrisonnet @k8s-triage-robot @thockin