New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write process start time to prometheus options so that scraping clients can parse it first #118820
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 8a6772eae7f3e8187b0317e0c0a3d503ba996e8b
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR leverages prometheus/client_golang#1278 which includes process start time in a header, allowing scraping clients to immediately start streaming and processing metrics rather than load the entire payload into memory first (since metrics are lexically ordered and process_start_time_seconds starts with a p and is therefore late in the payload.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: