Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_storage:stop using deprecated framework.ExpectError #120301

Merged
merged 1 commit into from May 16, 2024
Merged

e2e_storage:stop using deprecated framework.ExpectError #120301

merged 1 commit into from May 16, 2024

Conversation

liyuerich
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

test/e2e/storage stop using deprecated framework.ExpectError

Which issue(s) this PR fixes:

Ref # #115961

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @liyuerich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 31, 2023
@liyuerich
Copy link
Contributor Author

/cc @carlory could you help to take a look at it ?

@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2023
@liyuerich
Copy link
Contributor Author

/retest-required

@carlory
Copy link
Member

carlory commented Sep 4, 2023

/lgtm

/assign @xing-yang

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9186776b7f0e0fc00f1c80f913836ce8797bcd4

@liyuerich
Copy link
Contributor Author

/cc @xing-yang @mauriciopoppe could you help to review? thanks.

@mauriciopoppe
Copy link
Member

@xing-yang can help with the approval

@liyuerich
Copy link
Contributor Author

/cc @xing-yang could you help to review? any question please let me know. thanks.

@carlory
Copy link
Member

carlory commented Apr 19, 2024

/test pull-kubernetes-e2e-kind

@pohly
Copy link
Contributor

pohly commented Apr 22, 2024 •
edited

verify: test-code:

Errors:
test/e2e/storage/testsuites/volume_expand.go

The above files need to use framework.ExpectNoError(err) instead of 
Expect(err).NotTo(HaveOccurred()) or gomega.Expect(err).NotTo(gomega.HaveOccurred())

This indeed should be changed. framework.ExpectNoError is the only helper function that we do want to get used because it does a bit more than Gomega.

@liyuerich
Copy link
Contributor Author

verify: test-code:

Errors:
test/e2e/storage/testsuites/volume_expand.go

The above files need to use framework.ExpectNoError(err) instead of 
Expect(err).NotTo(HaveOccurred()) or gomega.Expect(err).NotTo(gomega.HaveOccurred())

This indeed should be changed. framework.ExpectNoError is the only helper function that we do want to get used because it does a bit more than Gomega.

yes , fixed in the latest commit

pohly
pohly suggested changes Apr 22, 2024
View reviewed changes
test/e2e/storage/persistent_volumes-local.go Outdated Show resolved Hide resolved
test/e2e/storage/persistent_volumes-local.go Outdated Show resolved Hide resolved
test/e2e/storage/volume_metrics.go Outdated Show resolved Hide resolved
@liyuerich
Copy link
Contributor Author

will fix the lint check failed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@liyuerich
Copy link
Contributor Author

it is conflict, let me fix it.

@liyuerich
Copy link
Contributor Author

PR needs rebase.

it is rebased, please review. thanks.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@liyuerich
e2e_storage:stop using deprecated framework.ExpectError
f55588f 
Signed-off-by: liyuerich <yue.li@daocloud.io>
@liyuerich
Copy link
Contributor Author

/retest

@carlory
Copy link
Member

carlory commented May 10, 2024

/test pull-kubernetes-e2e-gce-csi-serial

@liyuerich
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

@k8s-ci-robot
Copy link
Contributor

@liyuerich: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-cloud-provider-loadbalancer f55588f link false /test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liyuerich
Copy link
Contributor Author

#124546
from this PR, I got the similar message "the unrequired job /test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer always fails"
it looks like PR merge should not be blocked by this fail.

@liyuerich
Copy link
Contributor Author

liyuerich commented May 11, 2024 •
edited

@carlory @pohly
what do you think about it? any comment and question?

@carlory
Copy link
Member

carlory commented May 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5fda504e07d5ee7ca4caa40fddb2b1c98fa89bb

pohly
pohly approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liyuerich, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8c4e12 into kubernetes:master May 16, 2024
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 16, 2024
@liyuerich liyuerich deleted the storage branch May 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsi onsi onsi left review comments

@carlory carlory carlory left review comments

@bzsuni bzsuni bzsuni left review comments

@pohly pohly pohly approved these changes

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liyuerich @k8s-ci-robot @xing-yang @carlory @mauriciopoppe @gunit666 @pohly @onsi @bzsuni