-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenTelemetry Dependencies #121111
Conversation
/test pull-kubernetes-conformance-kind-ga-only-parallel |
/test pull-kubernetes-e2e-capz-windows-master |
9a0a3cf
to
80269d5
Compare
@@ -85,6 +84,7 @@ | |||
], | |||
"cloud.google.com/go/compute": [ | |||
"cloud.google.com/go/compute/metadata", | |||
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we understand the other three things in this list, and they will drop out after googleapis/go-genproto#1015 is finalized in ~march
what is tying otelgrpc to cloud.google.com/go/compute, and is there a near term plan (O(months)) that will drop this link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otelgrpc depends on that via google.golang.org/grpc
(v1.55.0 as of this PR update). Assuming grpc removes this dependency, it will be removed from otelgrpc in the subsequent release.
/assign @liggitt |
/test pull-kubernetes-e2e-capz-windows-master |
/lgtm |
LGTM label has been added. Git tree hash: c010da0f142dcb8613d1705c16fb02c64b34212a
|
Any chance this is going to get backported into 1.27? Thanks! |
@a7i |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update OpenTelemetry-Go dependencies. Work around a small regression in http attributes.
Special notes for your reviewer:
Based on #120241, but fixed tests, and rebased.
Does this PR introduce a user-facing change?