-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: util logs: add structured error helper #121984
Conversation
The wrapped error gets logged as "err=<err.Error()> errDetails=<additional value or group>" (text output, JSON is similar).
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold For agreement on approach in kubernetes/klog#357 and implementation in zapr + klog. |
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/sig architecture |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Not much interest and/or progress on "structured errors" lately, let's close for now. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The wrapped error gets logged as
err=<err.Error()> errDetails=<additional value or group>
(text output, JSON is similar). This can be used to provide more information about an error when it gets logged.Which issue(s) this PR fixes:
Related-to: kubernetes/klog#357
Special notes for your reviewer:
Depends on support in klog and zapr.
Does this PR introduce a user-facing change?
/cc @tallclair