-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: ginkgo v2.15.0, gomega v1.31.0 #122839
Conversation
2ac8601
to
1b42189
Compare
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The main reason for updating is support for reporting the cause of context cancellation: Ginkgo provides that information when canceling a context and Gomega polling code includes that when generating a failure message.
1b42189
to
18f0af1
Compare
/approve |
LGTM label has been added. Git tree hash: 2d5d37b26b31883c6d23185de94f56eb32a61b57
|
/assign @liggitt For dep approval in staging/src/k8s.io/api. |
/lgtm |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The main reason for updating is support for reporting the cause of context cancellation: Ginkgo provides that information when canceling a context and Gomega polling code includes that when generating a failure message.
Which issue(s) this PR fixes:
Related-to: onsi/gomega#716, onsi/ginkgo#1326
Special notes for your reviewer:
Does this PR introduce a user-facing change?