New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: fix ValidatingAdmissionPolicyList json tag #124568
base: master
Are you sure you want to change the base?
Conversation
Hi @xyz-li. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xyz-li The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig api-machinery |
If there is no |
/cc @cici37 |
Changelog suggestion -This change make api-server not omity the field `item` of ValidatingAdmissionPolicyList when ValidatingAdmissionPolicy is empty.
+Fixed a bug in the API server where empty collections of ValidatingAdmissionPolicies did not have an `items` field. |
BTW, the response to a list is formally a collection. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
a86641d
to
23fdc37
Compare
This change make api-server not omity the field `item` of ValidatingAdmissionPolicyList when ValidatingAdmissionPolicy is empty. So kubetl will print ValidatingAdmissionPolicyList correctly when ValidatingAdmissionPolicy is empty. Signed-off-by: xyz-li <hui0787411@163.com>
23fdc37
to
2cdccb3
Compare
/triage accepted |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Change the output when validatingadmissionpolicies is empty.
kubectl get --raw /apis/admissionregistration.k8s.io/v1/validatingadmissionpolicies
kubectl get --raw /api/v1/nodes
Which issue(s) this PR fixes:
Fixes #1593
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: