clean up LocalTrafficDetector construction / tests #124582
Conversation
It's already part of `config`
Also, only warn if the *primary* IP family is not correctly configured (since we don't actually know if the cluster is really dual-stack or not), and pass the pair of detectors to the proxiers as a map rather than an array.
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
danwinship
changed the title
k8s-ci-robot
added
area/ipvs
area/kube-proxy
sig/network
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a88dd147be2403bdfe99b3a8c4e36890d1b2af46
|
* LocalTrafficDetector construction and test improvements * Reorder getLocalDetector unit test fields so "input" args come before "output" args * Don't pass DetectLocalMode as a separate arg to getLocalDetector It's already part of `config` * Clarify test names in preparation for merging * Merge single-stack/dual-stack LocalTrafficDetector construction Also, only warn if the *primary* IP family is not correctly configured (since we don't actually know if the cluster is really dual-stack or not), and pass the pair of detectors to the proxiers as a map rather than an array. * Remove the rest of Test_getDualStackLocalDetectorTuple
What this PR does / why we need it:
More LocalTrafficDetector cleanup; this is basically part 2 of #124529, focusing on proxy construction and the associated unit tests.
I originally had done this as a single commit (along with parts of #124529) but it was impossible to figure out what was and wasn't changing in the unit tests so I split it up. But this is intended to merge with
tide/merge-method-squash, and in particular, the middle parts are gofmt'ed incorrectly (and the first commit is empty because it's just there to provide the final commit message, and the last commit is separate from the second-to-last commit only because it makes the diffs clearer).Does this PR introduce a user-facing change?
/kind cleanup
/label tide/merge-method-squash
/assign @tnqn