New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context-aware versions of retry.OnError and retry.OnConflict #124585
base: master
Are you sure you want to change the base?
Conversation
The current util methods for retry don't take in a context. This adds in versions which do take a context and respect the context cancellation or deadline. The implementation is rather simple, since the underlying method used, wait.ExponentialBackoff already has a context-aware version, wait.ExponentialBackoffWithContext. The documentation updates follow how the http.Request package refers to the context-aware version: https://pkg.go.dev/net/http@go1.22.2#NewRequest http.NewRequest refers to http.NewRequestWithContext and the latter contains the fuller documentation.
|
Welcome @steve-261370! |
Hi @steve-261370. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: steve-261370 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
1 similar comment
/easycla |
/cc @yliaog If you would have time to review? Thanks! |
The current util methods for retry don't take in a context. This adds in versions which do take a context and respect the context cancellation or deadline. The implementation is rather simple, since the underlying method used, wait.ExponentialBackoff already has a context-aware version, wait.ExponentialBackoffWithContext.
The documentation updates follow how the http.Request package refers to the context-aware version:
https://pkg.go.dev/net/http@go1.22.2#NewRequest
http.NewRequest refers to http.NewRequestWithContext and the latter contains the fuller documentation.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a golang context-aware version of two retry util methods.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: