Copy auth plugin to client-go repo #33334
Conversation
caesarxuchao
added
the
sig/api-machinery
|
I created the PR to see if it can pass the gke smoke test. There is a twist there. |
k8s-github-robot
added
size/XXL
| @@ -131,7 +131,7 @@ function mvfolder { | |||
| # the first rule is to convert import lines like `restclient "k8s.io/client-go/pkg/client/restclient"`, | |||
| # where a package alias is the same the package name. | |||
| find "${CLIENT_REPO}" -type f -name "*.go" -print0 | \ | |||
| xargs -0 sed -i "s,${src_package} \"${CLIENT_REPO_FROM_SRC}/${src},${dst_package} \"${CLIENT_REPO_FROM_SRC}/${dst},g" | |||
| xargs -0 sed -i "s,\<${src_package} \"${CLIENT_REPO_FROM_SRC}/${src},${dst_package} \"${CLIENT_REPO_FROM_SRC}/${dst},g" | |||
There was a problem hiding this comment.
I don't understand what this change is doing. Could you explain?
There was a problem hiding this comment.
It's to avoid rewriting such import:
import (
fcache "k8s.io/client-go/pkg/client/cache"
)
to
import (
fcore "k8s.io/client-go/core"
)
because when rewriting invocations, the script search for whole word, it does not rewrite the invocation from fcache to fcore.
| find "${CLIENT_REPO}" -type f -name "*.go" -print0 | xargs -0 sed -i "s,\<${src_package}\.\([a-zA-Z]\),${dst_package}\.\1,g" | ||
| fi | ||
|
|
||
| { grep -Rl "\"${CLIENT_REPO_FROM_SRC}/${src}" "${CLIENT_REPO}" || true ; } | while read target ; do |
There was a problem hiding this comment.
read -r so it doesn't mangle any backslashes
| # rewrite imports | ||
| # the first rule is to convert import lines like `restclient "k8s.io/client-go/pkg/client/restclient"`, | ||
| # where a package alias is the same the package name. | ||
| sed -i "s,\<${src_package} \"${CLIENT_REPO_FROM_SRC}/${src},${dst_package} \"${CLIENT_REPO_FROM_SRC}/${dst},g" ${target} |
There was a problem hiding this comment.
double quote ${target} here and below
caesarxuchao
force-pushed
the
copy-auth-plugin
branch
from
0ba3d7d
to
aba615c
Compare
k8s-github-robot
removed
the
needs-rebase
|
Jenkins Kubemark GCE e2e failed for commit aba615cd39efa9df5695302e31031a6cffc0bba3. Full PR test history. The magic incantation to run this job again is |
caesarxuchao
changed the title
|
Jenkins GCE e2e failed for commit aba615cd39efa9df5695302e31031a6cffc0bba3. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GKE smoke e2e failed for commit aba615cd39efa9df5695302e31031a6cffc0bba3. Full PR test history. The magic incantation to run this job again is |
|
Tests failed with, Looks like I need to update some import_known_versions.go. |
caesarxuchao
force-pushed
the
copy-auth-plugin
branch
from
aba615c
to
cfe006b
Compare
|
@krousey this PR is ready. PTAL. The commit "remove special clientrepo code from main repository gcp plugin" maybe the a little mysterious. Because our e2e test uses client-go, I used to add the special initialization code for auth plugin for client-go. It's not needed anymore. Because client-go/kubernetes/clientset.go will initialize the auth plugin for client-go. Please let me know if there are other non-obvious changes. Thanks! |
krousey
added
the
lgtm
k8s-github-robot
added
the
do-not-merge
caesarxuchao
added
release-note-none
rename plugin/pkg/client/auth/plugins.go package name to auth add the plugin import line in client-gen update import_known_versions for release_1_5 clientset change copy.sh
run copy.sh
caesarxuchao
force-pushed
the
copy-auth-plugin
branch
from
cfe006b
to
a397e30
Compare
caesarxuchao
added
lgtm
|
Reapplying the lgtm after squash. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
client-go doesn't copy the auth plugin. This causes user cannot access cluster run by GKE. User will see error "No Auth Provider found for name gcp".
This PR fixes this issue. It's marked as WIP because I'll need to rebase after #32906 gets merged. Also, the fix needs to be cherry-picked into 1.4 branch to update client-go/1.4.
This change is