Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global timeout flag #33958

Commits on Oct 14, 2016

  1. Add global timeout flag

    This patch adds a global timeout flag (viewable with `kubectl -h`) with
    a default value of `0s` (meaning no timeout).
    
    The timeout value is added to the default http client, so that zero
    values and default behavior are enforced by the client.
    
    **Example**
    ```
    $ kubectl get pods # no timeout flag set - default to 0s (which means no
    timeout)
    NAME                      READY     STATUS    RESTARTS   AGE
    docker-registry-1-h7etw   1/1       Running   1          2h
    router-1-uv0f9            1/1       Running   1          2h
    
    $ kubectl get pods --timeout=0 # zero means no timeout no timeout flag set
    NAME                      READY     STATUS    RESTARTS   AGE
    docker-registry-1-h7etw   1/1       Running   1          2h
    router-1-uv0f9            1/1       Running   1          2h
    
    $kubectl get pods --timeout=1ms
    Unable to connect to the server: net/http: request canceled while
    waiting for connection (Client.Timeout exceeded while awaiting headers)
    ```
    juanvallejo committed Oct 14, 2016
    Copy the full SHA
    fd087ca View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5dad125 View commit details
    Browse the repository at this point in the history