Automated cherry pick of #44570 #44862

[liggitt]

Cherry pick of #44570 #44862 on release-1.5.

#44570: Explicit namespace from kubeconfig should override in-cluster
#44862: Stop treating in-cluster-config namespace as an override

[k8s-reviewable]

This change is 

[liggitt]

if we cut another 1.5 release, this would be good to include.

unfortunately, the supporting test code for extracting kubectl and injecting it into a test pod didn't exist in 1.5, so the in-cluster-config tests can't pick back to 1.5 easily

[smarterclayton]

Lgtm wrt backport. Up to release manager, but agree that getting this straightened out so people aren't broken on upgrade is a good plan

[mwielgus]

@liggitt Did you test it manually on 1.5?

[pieterlange]

I just cherrypicked both commits into v1.5.7-beta0 and built kubectl manually.

Running this kubectl build in-pod:

/ # /usr/local/bin/kubectl version
Client Version: version.Info{Major:"1", Minor:"5+", GitVersion:"v1.5.7-beta.0.2+2f9aaeda2ccb5c-dirty", GitCommit:"2f9aaeda2ccb5ca77684973bfbb3e7d8abbcb46a", GitTreeState:"dirty", BuildDate:"2017-04-26T10:38:13Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.3+coreos.0", GitCommit:"8fc95b64d0fe1608d0f6c788eaad2c004f31e7b7", GitTreeState:"clean", BuildDate:"2017-02-15T19:52:15Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}

/ # kubectl apply -f /k8s/resources/debugger-rc.yaml 
error: the namespace from the provided object "staging" does not match the namespace "kube-system". You must pass '--namespace=staging' to perform this operation.

I'm still seeing the old behaviour, so this doesn't seem to be fixed..

//Edit
this seems to be more of a result of me not properly loading the changes from the client-go staging directory. Please ignore.

[pieterlange]

Verified this fixes the original issue on release-1.5.

/ # kubectl apply -f /k8s/resources/debugger-rc.yaml 
replicationcontroller "debugger" configured

I didn't run any other testsuites though.

[liggitt]

this seems to be more of a result of me not properly loading the changes from the client-go staging directory

actually, I didn't notice that there were still two copies of the client builder code in 1.5... fixed the version under pkg as well.

[pieterlange]

/bump so this gets picked up in 1.5.8 :(
@mwielgus @smarterclayton

[mwielgus]

@pieterlange please get the lgtm + approve label to have it merged.

[pieterlange]

@smarterclayton @saad-ali Please review & apply lgtm label

[liggitt]

I just ran manual tests and confirm this fixes both issues for 1.5

[smarterclayton]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

• pkg/client/OWNERS [liggitt,smarterclayton]
• staging/src/k8s.io/client-go/OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[liggitt]

tagging per #44901 (comment) and #44901 (comment)

[liggitt]

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

[k8s-github-robot]

Automatic merge from submit-queue

[k8s-cherrypick-bot]

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.