Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move crlf to kubectl/util #48298

Merged
merged 1 commit into from
Jun 30, 2017
Merged

move crlf to kubectl/util #48298

merged 1 commit into from
Jun 30, 2017

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jun 29, 2017

move crlf from pkg/util/crlf to pkg/kubectl/util/crlf

Ref: #48209

NONE

/assign @apelisse @monopole

cc: @pwittrock

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2017
@apelisse
Copy link
Member

Awesome Mengqi!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@mengqiy mengqiy mentioned this pull request Jun 29, 2017
Closed
@mengqiy
Copy link
Member Author

mengqiy commented Jun 29, 2017

Fix go fmt.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@apelisse
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@thockin
Copy link
Member

thockin commented Jun 30, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, mengqiy, thockin

Associated issue: 48209

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48295, 48298, 47339, 44910, 48037)

@k8s-github-robot k8s-github-robot merged commit 903a454 into kubernetes:master Jun 30, 2017
@mengqiy mengqiy deleted the kubectl_crlf branch June 30, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apelisse apelisse

@monopole monopole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mengqiy @apelisse @thockin @k8s-github-robot @monopole @k8s-ci-robot