Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new API version apps/v1beta2 #48746

Merged
merged 7 commits into from Jul 21, 2017
Merged

Add a new API version apps/v1beta2 #48746

merged 7 commits into from Jul 21, 2017

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Jul 11, 2017 •
edited

xref: #49135
This PR adds a new API version apps/v1beta2 which contains a copy (of types, conversions, and defaults) of apps/v1beta1 StatefulSet, Deployment, and their subresources. Note that apps/v1beta2 is still WIP and we will make breaking changes to it before releasing 1.8.

Moving core controllers (StatefulSet, Deployment, ReplicaSet, DaemonSet) to apps/v1beta2 is the first step of moving them to apps/v1 (GA).

This PR is a starting point for DaemonSet and ReplicaSet to move from /extensions to /apps and for Deployment and StatefulSet to make some breaking changes (e.g. new defaults and/or remove deprecated fields).

Add a new API version apps/v1beta2

@janetkuo janetkuo self-assigned this Jul 11, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
@k8s-github-robot k8s-github-robot added kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2017
@janetkuo janetkuo force-pushed the apps-v1beta2 branch 6 times, most recently from 38f2b3c to a926fde Compare July 12, 2017 00:11
@janetkuo janetkuo mentioned this pull request Jul 12, 2017
Merged
@janetkuo
Copy link
Member Author

@kubernetes/sig-apps-api-reviews

This is ready for review.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 12, 2017
@janetkuo janetkuo removed their assignment Jul 12, 2017
@janetkuo janetkuo assigned kow3ns and unassigned mfojtik and thockin Jul 12, 2017
0xmichalis
0xmichalis reviewed Jul 12, 2017
View reviewed changes
pkg/apis/apps/v1beta2/conversion.go Outdated
"fmt"

appsv1beta2 "k8s.io/api/apps/v1beta2"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill this newline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kow3ns
Copy link
Member

kow3ns commented Jul 12, 2017

/approve

@janetkuo
Copy link
Member Author

/assign @smarterclayton
need your approval

@janetkuo janetkuo added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 12, 2017
@janetkuo janetkuo added this to the v1.8 milestone Jul 12, 2017
@erictune
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2017
@crimsonfaith91
Copy link
Contributor

/retest

@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

Seems like a test infra problem: #49320

I0720 19:13:34.368] Your "OAuth 2.0 Service Account" credentials are invalid. Please run
I0720 19:13:34.368]   $ gcloud auth login
I0720 19:13:34.368] Duplicate type [0:0:4]
I0720 19:13:46.852] CommandException: 1 file/object could not be transferred.
I0720 19:13:48.606] FAILED

W0720 19:13:48.738] 2017/07/20 19:13:48 main.go:220: Something went wrong: failed to acquire k8s binaries: error during /go/src/k8s.io/release/push-build.sh --nomock --verbose --noupdatelatest --bucket=kubernetes-release-pull --ci --gcs-suffix=/pull-kubernetes-e2e-gce-etcd3: exit status 2

@janetkuo
Use AppsV1beta1 instead of Apps clienset
ae20c7e 
Apps clientset refers to AppsV1beta2 after apps/v1beta2 is created. Use
AppsV1beta1 for now before switching everything to AppsV1beta2.
@janetkuo
Fix golint failures by skipping auto-generated codes
f6c5392
@janetkuo
Mark apps/v1beta2 runtime Objects for code-gen
9b157d5
@janetkuo
Autogen
56f1634 
make clean && make generated_files && hack/update-all.sh
@janetkuo
Copy link
Member Author

/test pull-kubernetes-e2e-gce-etcd3

@janetkuo
Copy link
Member Author

Finally, all green again 😄

@janetkuo janetkuo mentioned this pull request Jul 21, 2017
Merged
kow3ns
kow3ns approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@kow3ns kow3ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/master/master.go Outdated
@@ -390,7 +389,8 @@ func DefaultAPIResourceConfigSource() *serverstorage.ResourceConfig {
authenticationv1beta1.SchemeGroupVersion,
autoscalingapiv1.SchemeGroupVersion,
appsv1beta1.SchemeGroupVersion,
appsv1beta2.SchemeGroupVersion,
// TODO: enable apps/v1beta2 by default before 1.8 release, after the API changes are done
// appsv1beta2.SchemeGroupVersion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned off by default +1.

staging/src/k8s.io/api/apps/v1beta2/types.go Outdated
@@ -29,13 +29,15 @@ const (
StatefulSetRevisionLabel = ControllerRevisionHashLabelKey
)

// WIP: This is not ready to be used and we plan to make breaking changes to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks marked as WIP. +1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2017
@kow3ns kow3ns mentioned this pull request Jul 21, 2017
Closed
11 tasks
@bgrant0607
Copy link
Member

Thanks much.
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, erictune, janetkuo, kow3ns

Associated issue: 49135

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2017
@janetkuo
Copy link
Member Author

janetkuo commented Jul 21, 2017 •
edited

The pull-kubernetes-unit test failure comes from a test just merged: #49353

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ae1ff1a into kubernetes:master Jul 21, 2017
@janetkuo janetkuo mentioned this pull request Jul 21, 2017
Closed
2 tasks
k8s-github-robot pushed a commit that referenced this pull request Jul 26, 2017
Merge pull request #49071 from foxish/foxish-api
4399fb2 
Automatic merge from submit-queue (batch tested with PRs 43443, 46193, 49071, 47252)

Add v1beta2.DaemonSet

Depends on #48746
Partly implements #49135

```release-note
Adding type apps/v1beta2.DaemonSet
```
k8s-github-robot pushed a commit that referenced this pull request Jul 28, 2017
Merge pull request #49238 from janetkuo/apps-v1beta2-rs
7056b5b 
Automatic merge from submit-queue (batch tested with PRs 49238, 49595, 43494, 47897, 48905)

Add apps/v1beta2.ReplicaSet

~Depends on #48746~ (merged)
~Depends on #49357~ (merged)
xref: #49135

```release-note
Add a new API object apps/v1beta2.ReplicaSet
```
k8s-github-robot pushed a commit that referenced this pull request Aug 9, 2017
Merge pull request #49340 from janetkuo/apps-v1beta2-dep-rollback
2bd2127 
Automatic merge from submit-queue

Deprecate Deployment .spec.rollbackTo field 

~Depends on #48746~ (merged)
xref: #46934, #49135

1. Deprecate Deployment field `.spec.rollbackTo` in `extensions/v1beta1` and `apps/v1beta1`, and remove the same field and `/rollback` endpoint from `apps/v1beta2` Deployment. 
1. Add an annotation `deprecated.deployment.rollback.to` in `apps/v1beta2` for conversion to/from other versions. 

Note: `apps/v1beta2` is new in 1.8 (and WIP), so it is okay to make breaking changes to it. 

```release-note
Deprecate Deployment .spec.rollbackTo field 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis left review comments

@kow3ns kow3ns kow3ns approved these changes

Assignees

@bgrant0607 bgrant0607

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet