Remove old, core/v1 specific constructs from RESTClient #48991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
smarterclayton
force-pushed
the
cleanup_restclient
branch
from
e49e8bd
to
a63b9a9
Compare
smarterclayton
added
the
sig/api-machinery
|
@kubernetes/sig-api-machinery-pr-reviews |
smarterclayton
force-pushed
the
cleanup_restclient
branch
2 times, most recently
from
8377f99
to
5bb014a
Compare
|
This makes resource.Helper a versioned interface (no field mapping) which it already was for non core API resources. |
All callers must use VersionedParameters, which no longer has special behavior for Kube resources.
smarterclayton
force-pushed
the
cleanup_restclient
branch
from
5bb014a
to
112e0fa
Compare
wojtek-t
added
release-note-none
wojtek-t
reviewed
Jul 17, 2017
| @@ -58,6 +58,7 @@ func (m *Helper) Get(namespace, name string, export bool) (runtime.Object, error | |||
| Resource(m.Resource). | |||
| Name(name) | |||
| if export { | |||
| // TODO: I should be part of GetOptions | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve
…On Mon, Jul 17, 2017 at 2:50 AM, Kubernetes Submit Queue < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *smarterclayton
<#48991#>*, *wojtek-t
<#48991 (comment)>*
*No associated issue*. Update pull-request body to add a reference to an
issue, or get approval with /approve no-issue
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- pkg/kubectl/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/OWNERS>
[smarterclayton,wojtek-t]
- staging/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/staging/OWNERS>
[smarterclayton,wojtek-t]
- test/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS>
[smarterclayton,wojtek-t]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48991 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p7sT9bbiWEp7doneeKD2TkdZqNfkks5sOwQogaJpZM4OZMmF>
.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smarterclayton, wojtek-t No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
smarterclayton
added
the
approved
|
Automatic merge from submit-queue |
smarterclayton
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that metav1 is abstracted from the APIs, RESTClient should also be agnostic to the core API.
LabelSelectorParamandFieldSelectorParam- useVersionedParamswithListOptionsUintParamVersionedParams- ParameterCodec now handles thattimeout) which is no longer set by most clients