Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve leading and trailing slashes on proxy subpaths #52933

Merged
merged 1 commit into from Sep 23, 2017
Merged

Preserve leading and trailing slashes on proxy subpaths #52933

merged 1 commit into from Sep 23, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 23, 2017 •
edited

subresource parsing was not populating path parameters correctly (leading and trailing slashes were being stripped)

this caused bad locations to be sent to the proxy, causing #52022. the first attempt to fix that (#52065) unconditionally prefixed '/', which broke the redirect case (#52813 #52729)

fixes #52813, fixes #52729

needs to be picked to 1.7 and 1.8

Restores redirect behavior for proxy subresources

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 23, 2017
@liggitt liggitt mentioned this pull request Sep 23, 2017
Closed
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 23, 2017
@liggitt liggitt added this to the v1.7 milestone Sep 23, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 23, 2017

kernel panic flake
/retest

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

Associated issue: 52022

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

This was referenced Sep 23, 2017
Merged
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit e0f7533 into kubernetes:master Sep 23, 2017
@liggitt liggitt deleted the proxy-subpath-slash branch September 25, 2017 13:52
k8s-github-robot pushed a commit that referenced this pull request Sep 25, 2017
Merge pull request #52946 from liggitt/automated-cherry-pick-of-#5293…
4dd73ef 
…3-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #52933

Cherry pick of #52933 on release-1.8.

#52933: Preserve leading and trailing slashes on proxy subpaths
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 2, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 2, 2017
Merge pull request #52947 from liggitt/automated-cherry-pick-of-#5293…
7db3566 
…3-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #52933

Cherry pick of #52933 on release-1.7.

#52933: Preserve leading and trailing slashes on proxy subpaths
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

kubectl proxy doesn't redirect to kubernetes dashboard correctly Kubectl Proxy to Dashboard broken in 1.7.6
7 participants
@liggitt @smarterclayton @k8s-github-robot @k8s-cherrypick-bot @ncdc @wojtek-t @k8s-ci-robot