Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apimachinery: remove ObjectCopier interface(s) #53525

Merged
merged 4 commits into from Oct 10, 2017
Merged

apimachinery: remove ObjectCopier interface(s) #53525

merged 4 commits into from Oct 10, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Oct 6, 2017 •
edited

The big commit is a mechanical, transitive removal of the copier interfaces in all structs and function calls.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2017
@sttts sttts force-pushed the sttts-scheme-copier-romoval branch from d736319 to 8621359 Compare October 6, 2017 12:24
@sttts sttts assigned smarterclayton and unassigned ncdc Oct 6, 2017
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2017
@k8s-ci-robot
Copy link
Contributor

@sttts: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 6, 2017
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2017
@sttts sttts force-pushed the sttts-scheme-copier-romoval branch 3 times, most recently from ec9c269 to db99a9d Compare October 6, 2017 14:40
@smarterclayton
Copy link
Contributor

/approve

@sttts sttts force-pushed the sttts-scheme-copier-romoval branch 2 times, most recently from 62d9f04 to 58402ab Compare October 6, 2017 16:38
@sttts sttts force-pushed the sttts-scheme-copier-romoval branch 2 times, most recently from 3315ffa to 747a6f5 Compare October 6, 2017 18:50
@sttts sttts force-pushed the sttts-scheme-copier-romoval branch from 747a6f5 to ecb65a6 Compare October 7, 2017 09:29
@sttts
Copy link
Contributor Author

sttts commented Oct 7, 2017

/retest

@sttts
Copy link
Contributor Author

sttts commented Oct 7, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, sttts

Associated issue requirement bypassed by: sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2017
This was referenced Oct 9, 2017
Merged
Merged
deads2k
deads2k reviewed Oct 10, 2017
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go
return nil, fmt.Errorf("UnstructuredCopier can't copy type %T", obj)
}

// serialize and deserialize to ensure a clean copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts this is the only one that concerns me. DeepCopy of unstructured works the way we need it to now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we didn't have deepcopy funcs on Unstructured at the time of writing. Now we do, using structural recursion instead of encode+decode. So potentially the new deepcopy is also faster.

@deads2k
Copy link
Contributor

deads2k commented Oct 10, 2017

one question. lgtm otherwise.

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53525, 53652). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit aaf14d4 into kubernetes:master Oct 10, 2017
cofyc added a commit to cofyc/external-storage that referenced this pull request Jan 26, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
3a0bac3 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
@cofyc cofyc mentioned this pull request Jan 26, 2018
Merged
cofyc added a commit to cofyc/external-storage that referenced this pull request Jan 26, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
38e3c19 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
cofyc added a commit to cofyc/external-storage that referenced this pull request Jan 26, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
b975861 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
cofyc added a commit to cofyc/external-storage that referenced this pull request Jan 30, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
c7537cc 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
@justinsb justinsb mentioned this pull request Feb 3, 2018
Merged
cofyc added a commit to cofyc/external-storage that referenced this pull request Dec 17, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
e434c21 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
cofyc added a commit to cofyc/sig-storage-local-static-provisioner that referenced this pull request Dec 17, 2018
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
f8efb99 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
w1ndy pushed a commit to w1ndy/iscsi-targetd-provisioner that referenced this pull request Jul 15, 2019
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
eb19384 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
humblec pushed a commit to humblec/gluster-block-external-provisioner that referenced this pull request Apr 21, 2020
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
c5e4b94 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
kmova pushed a commit to openebs-archive/openebs-k8s-provisioner that referenced this pull request Dec 16, 2020
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
2173bc1 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
davidmccormick pushed a commit to davidmccormick/sig-storage-local-static-provisioner that referenced this pull request Mar 31, 2021
@cofyc
Upgrade to kubernetes 1.9.2, Part 2: Non-Vendor changes.
ed9d34c 
- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @k8s-ci-robot @smarterclayton @k8s-github-robot @deads2k @ncdc