Update truncateBody to not truncate with high level
#54801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
apelisse
force-pushed
the
fix-broken-truncate
branch
from
c2bf6ba
to
fde38ad
Compare
| @@ -827,6 +827,8 @@ func (r *Request) transformResponse(resp *http.Response, req *http.Request) Resu | |||
| func truncateBody(body string) string { | |||
| max := 0 | |||
| switch { | |||
| case bool(glog.V(10)): | |||
| max = int(^uint(0) >> 1) | |||
There was a problem hiding this comment.
Or just return body?
And add a unit-tests to verify that it works properly.
apelisse
force-pushed
the
fix-broken-truncate
branch
from
fde38ad
to
a63ecc4
Compare
|
Updated, PTAL @smarterclayton Thanks |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
smarterclayton
added
the
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apelisse, smarterclayton No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a unit-tests to verify that it works properly.
What this PR does / why we need it:
Update
truncateBodyso that one can useV(10)to read the entire content of a HTTP response.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: