Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FlexVolume PV secret namespaces #56460

Merged
merged 2 commits into from Dec 16, 2017
Merged

Allow FlexVolume PV secret namespaces #56460

merged 2 commits into from Dec 16, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 28, 2017 •
edited

Completes the secret namespace PV refactor, so all PV volume sources that specify secrets can reference them outside the PVC namespace.

Finished the secret-related aspect of #32131

PersistentVolume flexVolume sources can now reference secrets in a namespace other than the PersistentVolumeClaim's namespace.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2017
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 28, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 28, 2017
@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2017

cc @kubernetes/sig-storage-api-reviews @kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 28, 2017
@liggitt liggitt assigned saad-ali and unassigned erictune Nov 28, 2017
@liggitt liggitt force-pushed the flex-pv-secret branch 2 times, most recently from 4ede0a3 to ecfe22d Compare November 28, 2017 04:59
@liggitt liggitt changed the title WIP - Allow FlexVolume PV secret namespaces Allow FlexVolume PV secret namespaces Nov 28, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2017
@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2017

/assign @rootfs

@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2017

/retest

@rootfs
Copy link
Contributor

rootfs commented Nov 28, 2017

cc @chakri-nelluri

rootfs
rootfs reviewed Nov 28, 2017
View reviewed changes
pkg/printers/internalversion/describe.go
@@ -1076,6 +1076,16 @@ func printAzureFilePersistentVolumeSource(azureFile *api.AzureFilePersistentVolu
azureFile.SecretName, ns, azureFile.ShareName, azureFile.ReadOnly)
}

func printFlexPersistentVolumeSource(flex *api.FlexPersistentVolumeSource, w PrefixWriter) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, there is never a unit test for flex

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and secrets injection is not tested anywhere

@rootfs
Copy link
Contributor

rootfs commented Nov 28, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@saad-ali
Copy link
Member

/assign @chakri-nelluri for review

@k8s-ci-robot
Copy link
Contributor

@saad-ali: GitHub didn't allow me to assign the following users: for, review.

Note that only kubernetes members can be assigned.

In response to this:

/assign @chakri-nelluri for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali
Copy link
Member

CC @verult

@kubernetes kubernetes deleted a comment from k8s-github-robot Dec 14, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 14, 2017
@liggitt
Copy link
Member Author

liggitt commented Dec 14, 2017

rebased, retagging

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

6 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@liggitt
Copy link
Member Author

liggitt commented Dec 15, 2017

regenerated

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@chakri-nelluri
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chakri-nelluri, liggitt, rootfs

Associated issue: #32131

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@liggitt
Copy link
Member Author

liggitt commented Dec 15, 2017 •
edited

yet another file needing regenerating, retagging
/retest

@liggitt
Copy link
Member Author

liggitt commented Dec 15, 2017

/retest

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56413, 56322, 56490, 56460, 56487). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d9b45d0 into kubernetes:master Dec 16, 2017
@php-coder php-coder mentioned this pull request Dec 19, 2017
Merged
@liggitt liggitt deleted the flex-pv-secret branch December 19, 2017 16:22
k8s-github-robot pushed a commit that referenced this pull request Jan 2, 2018
Merge pull request #57399 from php-coder/fix_flex_pvs_describe
a0f8dd8 
Automatic merge from submit-queue (batch tested with PRs 57399, 57751, 57475). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

printFlexPersistentVolumeSource: fix format

**What this PR does / why we need it**:
This PR fixes invalid format.

**Special notes for your reviewer**:
Addresses #56460 (comment)
Fixes #57694

**Release note**:
```release-note
NONE
```

PTAL @liggitt 
CC @simo5
@klausenbusk klausenbusk mentioned this pull request May 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder left review comments

@verult verult verult left review comments

@rootfs rootfs rootfs left review comments

@chakri-nelluri chakri-nelluri chakri-nelluri approved these changes

Assignees

@jsafrane jsafrane

@rootfs rootfs

@chakri-nelluri chakri-nelluri

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet